Simplified EC patch #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The existing patch replaced the entire content of the upstream ChromeOS EC getversion.sh with a single line. This is brittle, as any change to the upstream file will cause failed of the patch to apply going forware. This change modifies the patch to insert two lines at the very top of the script, which does our logic and exits without the bulk of the script ever running. That way, most changes in the upstream file will not interfere with the ability of the patch to continue to apply. Signed-off-by: Jes B. Klinke <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing patch replaced the entire content of the upstream ChromeOS EC getversion.sh with a single line. This is brittle, as any change to the upstream file will cause failed of the patch to apply going forware.
This change modifies the patch to insert two lines at the very top of the script, which does our logic and exits without the bulk of the script ever running. That way, most changes in the upstream file will not interfere with the ability of the patch to continue to apply.