[dv,alerts] Fix alert_sva_active to have correct reset polarity #24543
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Eitan Shapira <[email protected]>
rswarbrick
approved these changes
Sep 10, 2024
|
Thanks! |
|
@andreaskurth can you please merge it also to earlgrey_1.0.0 branch? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fix the reset polarization of the alert_sva_active flag in the alert_esc_if which was inverted.
The alerts SVA should be active only when the reset is deasserted, which means when rst_n = 1.
This means alert_sva_active should be with the same polarization as rst_n, hence the fix.