[ci,check-generated] Handle empty text in CMDGEN #24993
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This recent push adds a "top_and_cmdgen" target the Makefile to avoid passing multiple targets to a single make invocation. |
Change ci/scripts/check-generated.sh to run both top and cmdgen when checking for the topgen generated artifacts. This is to support template md files having no text between the BEGIN and END markers so they can handle multi-top. Add a separate "cmdgen" target in the hw/Makefile and describe that in the README.md for contributing to documentation. Fixes lowRISC#24991 Signed-off-by: Guillermo Maturana <[email protected]>
andreaskurth
approved these changes
Nov 3, 2024
jwnrt
approved these changes
Nov 4, 2024
HU90m
approved these changes
Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change ci/scripts/check-generated.sh to run both top and cmdgen when checking for the topgen generated artifacts. This is to support template md files having no text between the BEGIN and END markers so they can handle multi-top.
Add a separate "cmdgen" target in the hw/Makefile and describe that in the README.md for contributing to documentation.
Fixes #24991