[hw,pwrmgr,rtl] Support more than 1 rom_ctrl input #25169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Razer6
requested review from
rswarbrick,
andreaskurth,
vogelpi and
matutem
and removed request for
a team and
msfschaffner
Razer6
force-pushed
the
pwrmgr-rom-ctrl
branch
2 times, most recently
from
7efa7a6
to
9a87a97
Compare
matutem
reviewed
Nov 17, 2024
hw/ip_templates/pwrmgr/dv/tb.sv.tpl
Outdated
| % if NumRomInputs > 1: | ||
| // TODO: Properly model rom_ctrl if there are more than 1 | ||
| % endif | ||
| % for i in range(NumRomInputs-1): |
There was a problem hiding this comment.
I don't understand what this line is doing. I guess it covers for pwrmgr_if to have a single rom_ctrl, and that is the actual TODO. Eventually it will be an array. Could you clarify the TODO so this is more understandable and it is clearer what needs to be done?
matutem
reviewed
Nov 17, 2024
matutem
requested changes
Nov 17, 2024
Razer6
force-pushed
the
pwrmgr-rom-ctrl
branch
from
9a87a97
to
3af77c0
Compare
Darjeeling has 2 rom_ctrls. Template the rom_ctrl input to support more than 1 rom_ctrl input. Signed-off-by: Robert Schilling <[email protected]>
Razer6
force-pushed
the
pwrmgr-rom-ctrl
branch
from
3af77c0
to
d34be37
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Darjeeling has 2 rom_ctrls. Template the rom_ctrl input to support more than 1 rom_ctrl input.
This pulls over work from the integrated_dev branch.