Skip to content

Commit

Permalink
[Feature] Add helm lint check in Github Actions (ray-project#554)
Browse files Browse the repository at this point in the history
Adds a helm lint check to verify that charts are well-formed and properly formatted.
  • Loading branch information
kevin85421 authored Sep 13, 2022
1 parent e27e0f6 commit 3276916
Show file tree
Hide file tree
Showing 2 changed files with 71 additions and 11 deletions.
61 changes: 61 additions & 0 deletions .github/workflows/helm-lint.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,61 @@
name: Lint and Test Charts

on:
push:
branches:
- master
pull_request:
branches: [ master ]

jobs:
lint-test-helm-3-4:
runs-on: ubuntu-latest
steps:
- name: Checkout Code
uses: actions/checkout@v3
with:
fetch-depth: 0

- name: Set up Helm
uses: azure/[email protected]
with:
version: v3.4.1

- uses: actions/setup-python@v4
with:
python-version: 3.7

- name: Set up chart-testing
uses: helm/[email protected]

- name: Run chart-testing (lint)
# Run 'helm lint', version checking, YAML schema validation on 'Chart.yaml',
# YAML linting on 'Chart.yaml' and 'values.yaml', and maintainer.
# [Doc]: https://github.com/helm/chart-testing/blob/main/doc/ct_lint.md
run: ct lint --all --chart-dirs helm-chart/ --validate-maintainers=false

lint-test-helm-3-9:
runs-on: ubuntu-latest
steps:
- name: Checkout Code
uses: actions/checkout@v3
with:
fetch-depth: 0

- name: Set up Helm
uses: azure/[email protected]
with:
version: v3.9.4

- uses: actions/setup-python@v4
with:
python-version: 3.7

- name: Set up chart-testing
uses: helm/[email protected]

- name: Run chart-testing (lint)
# Run 'helm lint', version checking, YAML schema validation on 'Chart.yaml',
# YAML linting on 'Chart.yaml' and 'values.yaml', and maintainer.
# [Doc]: https://github.com/helm/chart-testing/blob/main/doc/ct_lint.md
run: ct lint --all --chart-dirs helm-chart/ --validate-maintainers=false
21 changes: 10 additions & 11 deletions helm-chart/ray-cluster/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -21,10 +21,10 @@ head:
key: value
initArgs:
port: '6379'
redis-password: 'LetMeInRay' # Deprecated since Ray 1.11 due to GCS bootstrapping enabled
redis-password: 'LetMeInRay' # Deprecated since Ray 1.11 due to GCS bootstrapping enabled
dashboard-host: '0.0.0.0'
num-cpus: '1' # can be auto-completed from the limits
node-ip-address: $MY_POD_IP # auto-completed as the head pod IP
num-cpus: '1' # can be auto-completed from the limits
node-ip-address: $MY_POD_IP # auto-completed as the head pod IP
block: 'true'
containerEnv:
- name: MY_POD_IP
Expand All @@ -38,14 +38,14 @@ head:
limits:
cpu: 1
requests:
cpu: 1
cpu: 1
annotations: {}
nodeSelector: {}
tolerations: []
affinity: {}
volumes:
- name: log-volume
emptyDir: { }
emptyDir: {}
volumeMounts:
- mountPath: /tmp/ray
name: log-volume
Expand Down Expand Up @@ -86,11 +86,11 @@ worker:
ports:
- containerPort: 80
protocol: TCP
resources:
resources:
limits:
cpu: 1
requests:
cpu: 200m
cpu: 200m
annotations:
key: value
nodeSelector: {}
Expand Down Expand Up @@ -141,11 +141,11 @@ additionalWorkerGroups:
ports:
- containerPort: 80
protocol: TCP
resources:
resources:
limits:
cpu: 1
requests:
cpu: 200m
cpu: 200m
annotations:
key: value
nodeSelector: {}
Expand All @@ -157,8 +157,7 @@ additionalWorkerGroups:
volumeMounts:
- mountPath: /tmp/ray
name: log-volume



headServiceSuffix: "ray-operator.svc"

service:
Expand Down

0 comments on commit 3276916

Please sign in to comment.