Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Language activity converts C++ to C #114

Closed
LunarWatcher opened this issue Feb 6, 2021 · 2 comments · Fixed by #117
Closed

Language activity converts C++ to C #114

LunarWatcher opened this issue Feb 6, 2021 · 2 comments · Fixed by #117

Comments

@LunarWatcher
Copy link

I work with C++, and don't work with C. The language activity section yet drops the ++ and replaces it with nothing, yielding an incorrect language. This is specifically limited to language activity -- most used languages works fine

image

@lowlighter
Copy link
Owner

Thanks for reporting this!
It's probably related to the regex parsing github/linguist output:

.split("\n").map(line => line.match(/(?<value>[\d.]+)%\s+(?<language>\w+)/)?.groups).filter(line => line)

It only use \w class to detect languages, which does not include special characters like + so that's probably why it's dropping them

I'll take a look next week 👍

@lowlighter
Copy link
Owner

Should be fixed in #117

@github-actions github-actions bot locked and limited conversation to collaborators Mar 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
2 participants