Performance drop (docker file always rebuilt even on official action)

[Nixinova]

Metrics runs have had a consistent large uptick in generation time after July 1 with no change to the settings by me from Jun 27 - Jul 6.

Run	UTC
	2 Jul 18:22 1 Jul 18:21 30 Jun 23:05 (custom run) 30 Jun 18:21

[lowlighter]

I don't see any recent changes that could have caused this performance drop 😕

There's a new option delay which can be used to make the workflow longer and prevent GitHub rate abuse limit, but it should be off by default.

If it suddenly increased and you use the detailed language feature, it could come from here since it basically clone your repos to compute stats so maybe it could correlate with you recent work?

[spenserblack]

git log --since="June 30 2021" --until="July 2 2021"

Only outputs 2 commits (5a15dfd and f22a6d6), neither of them look like they should cause such a performance drop.
If you use lowlighter/metrics@698326000340e702ee464d8fafb59ee89fff9cfd (I've never specified a specific commit for an action before, but I think that's how it's done), do you still experience the performance drop?

[Nixinova]

Here's a collection of runs

v3.10 (June 1) takes 6min but the commits on June 14 and early July take only 3-4min, and v3.11 (this week) also takes 6min. Not sure what's going on here, I'll do more tests.

[thib3113]

Hello, maybe not related, but it seems the dockerFile is always rebuilded ( even using official repo + setting use_prebuilt_image : yes ) ....

And following the documentation : Faster execution with prebuilt docker images

already installed dependencies which will cut execution time from ~5 minutes to ~1 minute.

So, it can explain this bug ?

[lowlighter]

@thib3113 Nice catch 👍 !

It seems the following line doesn't work anymore:

metrics/source/app/action/action.yml

Line 58 in f9df323

if [[ $METRICS_SOURCE == "lowlighter" ]]; then

Because the line which try to extract the action owner doesn't get correctly parsed:

metrics/source/app/action/action.yml

Lines 44 to 46 in f9df323

	# Source repository (picked from action name)
	METRICS_SOURCE=$(echo $METRICS_ACTION | sed -E 's/metrics.*?$//g')
	echo "Source: $METRICS_SOURCE"

  Source: __lowlighter_
  Version: 3.11.0
  Image tag: v3.11
  Using a forked version
  Image name: metrics:forked-3.11.0
  Image metrics:forked-3.11.0 is not present locally, rebuilding it from Dockerfile

For some reason, additional underscores got added but not sure why.
Since it tries to match my login but it doesn't match, the action thinks it has been forked and is rebuild from scratch from the dockerfile like you said previously

If this is always underscores getting added, maybe we should just add an additional sed to remove them, I don't think they're allowed in GitHub usernames

[Nixinova]

I think that is indeed the issue, turning timestamps on, Docker takes 4 min to rebuild:

[Nixinova]

Yep, that fixed it 👍