Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Isocalendar is unable to count streak after 182 in half mode. #512

Closed
Tarun-Kamboj opened this issue Sep 3, 2021 · 4 comments
Closed

Isocalendar is unable to count streak after 182 in half mode. #512

Tarun-Kamboj opened this issue Sep 3, 2021 · 4 comments
Labels
☑️ archived 🐛 bug

Comments

@Tarun-Kamboj
Copy link

My actual streak :

Isocalendar showing :
@Nixinova
Copy link
Contributor

Nixinova commented Sep 3, 2021

That's cause your calendar is on half year mode. It doesn't load anything from more than 365/2=182 days ago.

@Nixinova
Copy link
Contributor

Nixinova commented Sep 3, 2021

Maybe a check could be added like if (streak >= 181) streak += "+" though to help.

@lowlighter
Copy link
Owner

I think it's worth to get the accurate number.

To save queries we can fetch further data only when the streak is complete like in this case

lowlighter added a commit that referenced this issue Sep 6, 2021
@lowlighter
feat(plugins/isocalendar): make stats based on overall account contri…
b32da06 
…butions rather than restricted to `isocalendar.duration` (closes #512)
@lowlighter
Copy link
Owner

This will be available with 3.14 👍

@github-actions github-actions bot locked and limited conversation to collaborators Sep 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
☑️ archived 🐛 bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@lowlighter @Nixinova @Tarun-Kamboj