Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add when it was played for spotify in recent mode #104

Merged
merged 5 commits into from
Feb 5, 2021
Merged

add when it was played for spotify in recent mode #104

merged 5 commits into from
Feb 5, 2021

Conversation

Milo123459
Copy link
Contributor

This pr only effects spotify in recent mode

This displays when the music was played!

@github-actions github-actions bot added the core label Feb 5, 2021
@Milo123459
Copy link
Contributor Author

That's why it was failing!

@lowlighter lowlighter merged commit a7f9f71 into lowlighter:master Feb 5, 2021
@lowlighter
Copy link
Owner

Thanks for contributing!

@Milo123459
Copy link
Contributor Author

Wait, @lowlighter when will this be available? Like, can I do plugin_music_played_at: yes in my workflow and it'll start "working"?

@lowlighter
Copy link
Owner

Currently your addition is available on the following:

  • lowlighter@master
  • Milo123459@update-spotify- (your PR branch)
  • Milo123459@master (if you're up-to-date)

It's not yet available on lowlighter@latest as it stills points to v3.3.
I usually try to integrate several bugfixes/features before publishing a new release so it lets a bit of time for testing and ensuring that releases won't be too buggy and break everyone's workflow
You can see @master as a beta version and @latest as a stable version 🙂

So tldr; use either lowlighter@master or Milo123459@master after pulling your changes in it to use your new option

@Milo123459
Copy link
Contributor Author

Cool! Thanks :D

@lowlighter lowlighter mentioned this pull request Feb 5, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Mar 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants