Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to node 16 #390

Merged
merged 21 commits into from
Jun 17, 2021
Merged

Upgrade to node 16 #390

merged 21 commits into from
Jun 17, 2021

Conversation

Zenoo
Copy link
Contributor

@Zenoo Zenoo commented Jun 16, 2021

Node 15 introduced some vulnerabilities:




Upgrading to v16 fixes those.

I also removed a line in the analysers file that caused the generation of the habits metrics to fail (which took me quite some time to figure out):

await imports.fs.rmdir(path, {recursive:true})

@lowlighter
Copy link
Owner

Thanks a lot for this PR 🙂

Seems there is an issue with community templates causing many tests to fail (probably comes from source/app/metrics/setup.mjs editions). I didn't dig it too much in details, but maybe rmdir and rm have slightly different behaviours ?

I had errors about removing unexisting dirs too but thought it was only on my computer since action isn't complaining.
Maybe it's linked and checking if directory exists before removing it would solve it

@Zenoo
Copy link
Contributor Author

Zenoo commented Jun 17, 2021

Oh, I just realized I forgot to add an option to the rm() method for it to be 100% compatible with the old one.
Fixing it now.

@lowlighter lowlighter merged commit 2afece0 into lowlighter:master Jun 17, 2021
@lowlighter
Copy link
Owner

Thanks!

@github-actions github-actions bot locked and limited conversation to collaborators Jul 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants