Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix languages plugin crash #416

Merged
merged 1 commit into from
Jul 18, 2021
Merged

Fix languages plugin crash #416

merged 1 commit into from
Jul 18, 2021

Conversation

Nixinova
Copy link
Contributor

Adds an optional chain because file.repo_url is nullable

`file.repo_url` is nullable
@Nixinova Nixinova changed the title Optional chaining Fix languages plugin crash Jul 16, 2021
@Nixinova
Copy link
Contributor Author

This may just be a bandaid; why can file.repo_url be undefined?

@lowlighter lowlighter merged commit d258f58 into lowlighter:master Jul 18, 2021
@lowlighter
Copy link
Owner

This may just be a bandaid; why can file.repo_url be undefined?

I'm not sure why. Maybe if the repo got deleted then GitHub keep the event but removes the url ?

JayantGoel001 referenced this pull request in JayantGoel001/metrics Jul 18, 2021
@Nixinova Nixinova deleted the patch-1 branch July 18, 2021 20:11
@lowlighter lowlighter mentioned this pull request Jul 23, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Aug 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

File url can be undefined
2 participants