-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix a few grammatical errors #44
Conversation
Change test from ">0" to "≠0" as that is how pluralization is done in English.
@@ -897,12 +897,12 @@ | |||
|
|||
<% if (base.metadata) { %> | |||
<footer> | |||
<span>These metrics <%= !computed.token.scopes.includes("repo") ? "does not include all" : "includes" %> private contributions<% if ((config.timezone?.name)&&(!config.timezone?.error)) { %>, timezone <%= config.timezone.name %><% } %></span> | |||
<span>These metrics <%= !computed.token.scopes.includes("repo") ? "do not include all" : "include" %> private contributions<% if ((config.timezone?.name)&&(!config.timezone?.error)) { %>, timezone <%= config.timezone.name %><% } %></span> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The timezone transclusion seems a bit misplaced but not sure what to do with it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I think it's beceause it's in italic so it get cropped but's that's ok, I planned to add more padding to the right later 👍
@@ -897,12 +897,12 @@ | |||
|
|||
<% if (base.metadata) { %> | |||
<footer> | |||
<span>These metrics <%= !computed.token.scopes.includes("repo") ? "does not include all" : "includes" %> private contributions<% if ((config.timezone?.name)&&(!config.timezone?.error)) { %>, timezone <%= config.timezone.name %><% } %></span> | |||
<span>These metrics <%= !computed.token.scopes.includes("repo") ? "do not include all" : "include" %> private contributions<% if ((config.timezone?.name)&&(!config.timezone?.error)) { %>, timezone <%= config.timezone.name %><% } %></span> | |||
<span>Last updated <%= new Date().toGMTString() %> with lowlighter/metrics@<%= meta.version %></span> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you tell me what's the output for just using <%= new Date() %>
?
For me it'll return Sat Jan 09 2021 09:50:28 GMT+0100 (heure normale d’Europe centrale)
which is a bit long but maybe that's just because of my locale set to French
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The bit in brackets is just the full name of the timezone in your locale, so for me it would be Sun Jan 10 2021 07:57:40 GMT+1300 (New Zealand Daylight Time)
. Note however that I didn't touch that line, it's just in red for some reason.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah yes never mind, didn't notice it was syntaxic coloration
Thanks for contributing! |
Pull request description
Just fixes a few grammar and punctuation errors in the outputted svgs. See diff.
Additional context and screenshots
None