Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Complementary lang colors #76

Merged
merged 4 commits into from
Jan 23, 2021
Merged

Complementary lang colors #76

merged 4 commits into from
Jan 23, 2021

Conversation

b3z
Copy link
Contributor

@b3z b3z commented Jan 23, 2021

I tried implementing complementary colors as a preset.
I didn't test it in your workflow but I tested the color set on my own page. So you might need to test before merge.

image

Maybe my example is not too good because one bar is filling almost everything but you get the idea of complementary colors.

Also I added it to your test file. Not sure if that is right. Might have to check that.

Complementary colors reference: see here

@lowlighter
Copy link
Owner

Thanks looks good to me 👍🏼
I updated the tests since it was overriding other properties making the code ql fail.

@lowlighter lowlighter merged commit 5e0ee81 into lowlighter:master Jan 23, 2021
@b3z
Copy link
Contributor Author

b3z commented Jan 23, 2021

Thanks looks good to me 👍🏼
I updated the tests since it was overriding other properties making the code ql fail.

alright.

@b3z b3z deleted the complementary-lang-colors branch January 23, 2021 13:45
@github-actions github-actions bot locked and limited conversation to collaborators Mar 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants