Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deserialize handles multiple events in ics #36

Merged
merged 11 commits into from
Sep 5, 2019
Merged

Conversation

ericdude4
Copy link
Contributor

Current implementation deserializes only the last event in the calendar and returns the single event. This has to be a bug since an .ics file can contain any number of events.

I included some passing tests.

Some other improvements:

  • support for empty keys
 BEGIN:VEVENT
 DESCRIPTION:
 END:VEVENT
  • support for date strings since this is common in Google calendar .ics links
BEGIN:VEVENT
DTSTART;VALUE=DATE:20190624
DTEND;VALUE=DATE:20190625
END:VEVENT

@lpil
Copy link
Owner

lpil commented Aug 11, 2019

Hi, sorry could you rebase to fix the merge conflicts?

@ericdude4
Copy link
Contributor Author

@lpil done! Thanks for getting back to me.

@dhanson358
Copy link

Hate to pester, but any ETA on this being merged? I have some need for this exact functionality!

@ericdude4
Copy link
Contributor Author

ericdude4 commented Aug 29, 2019

@dhanson358 I am just waiting for him to merge it in. You can always use my forked repository for the time being.

lib/icalendar/deserialize.ex Outdated Show resolved Hide resolved
mix.exs Outdated Show resolved Hide resolved
@lpil lpil merged commit b7fdbb2 into lpil:master Sep 5, 2019
@lpil
Copy link
Owner

lpil commented Sep 5, 2019

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants