Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to the latest regex crate #20

Merged
merged 1 commit into from
Oct 31, 2023
Merged

Conversation

fukusuket
Copy link
Contributor

@fukusuket fukusuket commented Oct 29, 2023

Thank you so much for awesome tool :)
I noticed some newly supported grammars in the latest Regex crate, so I created a PR.

What Changed

Upgrade regex create version from 1.7.0 (2022-11-05) to 1.10.2 (2023-10-16) .

There are several new grammars supported in recent releases. for example:
1.8.0 (2023-04-20)

1.10.0 (2023-10-09)

Evidence

I confirmed that the compilation is successful.

fukusuke@fukusukenoAir rustexp % cargo -V
cargo 1.73.0 (9c4383fb5 2023-08-26)

fukusuke@fukusukenoAir rustexp % rustup -V
rustup 1.26.0 (5af9b9484 2023-04-05)
info: This is the version for the rustup toolchain manager, not the rustc compiler.
info: The currently active `rustc` version is `rustc 1.73.0 (cc66ad468 2023-10-03)`

fukusuke@fukusukenoAir rustexp % cargo test
    Finished test [unoptimized + debuginfo] target(s) in 0.06s
     Running unittests src/main.rs (target/debug/deps/rustexp-1dd5bea5b58d4f9e)

running 5 tests
test tests::test_format_captures_no_matches ... ok
test tests::test_format_captures_no_captures ... ok
test tests::test_format_captures_all ... ok
test tests::test_format_captures_some ... ok
test tests::test_format_captures_some_2 ... ok

test result: ok. 5 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.01s

fukusuke@fukusukenoAir rustexp % trunk build --release
2023-10-29T06:01:13.938094Z  INFO 📦 starting build
2023-10-29T06:01:13.938668Z  INFO spawning asset pipelines
2023-10-29T06:01:14.004588Z  INFO building rustexp
2023-10-29T06:01:14.004601Z  INFO copying & hashing css path="main.css"
2023-10-29T06:01:14.004602Z  INFO copying & hashing icon path="favicon.ico"
2023-10-29T06:01:14.004948Z  INFO finished copying & hashing css path="main.css"
2023-10-29T06:01:14.005039Z  INFO finished copying & hashing icon path="favicon.ico"
    Finished release [optimized] target(s) in 0.02s
2023-10-29T06:01:14.063074Z  INFO fetching cargo artifacts
2023-10-29T06:01:14.108333Z  INFO processing WASM for rustexp
2023-10-29T06:01:14.109817Z  INFO calling wasm-bindgen for rustexp
2023-10-29T06:01:14.150808Z  INFO copying generated wasm-bindgen artifacts
2023-10-29T06:01:14.151745Z  INFO applying new distribution
2023-10-29T06:01:14.153404Z  INFO ✅ success

@fukusuket
Copy link
Contributor Author

@fukusuket
Copy link
Contributor Author

Copy link
Owner

@lpil lpil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@lpil lpil merged commit a41933f into lpil:main Oct 31, 2023
2 checks passed
@fukusuket fukusuket deleted the update-regex-crate branch October 31, 2023 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants