Cargo.toml: allow users to specify tls implementation #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @lpotthast would it be possible to get a review on these two open PRs? |
|
@lpotthast I'm interest too |
|
Tanks for the PR! Looking at the current feature declarations in
|
reqwest now takes care itself of activating the optional `serde_json` dependency under the already activated `json` feature [1]. [1] https://github.com/seanmonstar/reqwest/blob/v0.12.0/CHANGELOG.md#v0120
|
Thanks for the review! I opened #19 as a preceding PR to update |
We allow the user to choose between the default native-tls and rustls TLS implementations for the reqwest dependency. The default behaviour remains activating the previously used, default native-tls implementation, thus not breaking any clients.
Done.
Done.
Done. |
lpotthast
approved these changes
Mar 24, 2024
|
Looks good! Thanks for the quick changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We allow the user to choose between the default
native-tls and rustls TLS implementations for the
reqwest dependency. The default behaviour remains
activating the previously used, default native-tls implementation, thus not breaking any clients.
Closes #11.