fixes for windows builds warnings #122
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Maybe remove params like... at all?
oktonion
changed the title
|
Commit 4e822f1 is a bit of hiding the problem than solving it. I don't know why there are unused function params and at this point may be we should just remove these at all. Anyway "unused function parameter" warnings are eliminated for now. |
|
Any thoughts on this? |
|
I am not sure this is the right approach.
…On Tue, May 19, 2020 at 9:39 AM Aleksandr ***@***.***> wrote:
Any thoughts on this?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
|
@lsalzman so what the right thing would be in your view? |
Croydon
reviewed
Sep 24, 2023
| @@ -4,10 +4,16 @@ | |||
| */ | |||
| #ifdef _WIN32 | |||
|
|
|||
| #ifndef _WINSOCK_DEPRECATED_NO_WARNINGS | |||
| #define _WINSOCK_DEPRECATED_NO_WARNINGS | |||
There was a problem hiding this comment.
This is just muting warnings, not fixing them
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.