Merge pull request #1312 from jeremyf/removing-deprecation-warning

Removing warning for open-uri calling Kernel#open

lib/yard/cli/diff.rb

@@ -161,7 +161,10 @@ def load_gem_data(gemfile)
         url = "http://rubygems.org/downloads/#{gemfile}"
         log.info "Searching for remote gem file #{url}"
         begin
-          open(url) {|io| expand_and_parse(gemfile, io) }
+          # Note: In Ruby 2.4.x, URI.open is a private method. After
+          # 2.5, URI.open behaves much like Kernel#open once you've
+          # required 'open-uri'
+          OpenURI.open_uri(url) {|io| expand_and_parse(gemfile, io) }
           return true
         rescue OpenURI::HTTPError
           nil # noop

spec/cli/diff_spec.rb

@@ -236,8 +236,8 @@ def baz; BAR end
       expect(File).to receive(:directory?).with('gem2.gem').and_return(false)
       expect(File).to receive(:exist?).with('gem1.gem').and_return(false)
       expect(File).to receive(:exist?).with('gem2.gem').and_return(false)
-      expect(@diff).to receive(:open).with('http://rubygems.org/downloads/gem1.gem')
-      expect(@diff).to receive(:open).with('http://rubygems.org/downloads/gem2.gem')
+      expect(OpenURI).to receive(:open_uri).with('http://rubygems.org/downloads/gem1.gem')
+      expect(OpenURI).to receive(:open_uri).with('http://rubygems.org/downloads/gem2.gem')
       allow(FileUtils).to receive(:mkdir_p)
       allow(Gem::Package).to receive(:open)
       allow(FileUtils).to receive(:rm_rf)