Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Workaround for broken Browser Back for anchors. Fixes #1071 #1228

Merged
merged 1 commit into from
Mar 31, 2019
Merged

Workaround for broken Browser Back for anchors. Fixes #1071 #1228

merged 1 commit into from
Mar 31, 2019

Conversation

thomthom
Copy link
Contributor

Description

This addresses #1071 where the Browser Back button does not scroll the view into correct location when anchor address changes.

Completed Tasks

  • I have read the Contributing Guide.
  • The pull request is complete (implemented / written).
  • Git commits have been cleaned up (squash WIP / revert commits).
  • I wrote tests and ran bundle exec rake locally (if code is attached to PR).

@coveralls
Copy link

Coverage Status

Coverage increased (+0.09%) to 93.733% when pulling 6866751 on thomthom:dev-fix-anchor-history into 565343f on lsegal:master.

@lsegal lsegal merged commit 7579761 into lsegal:master Mar 31, 2019
@lsegal
Copy link
Owner

lsegal commented Mar 31, 2019

Thanks! Sorry for the delay on this.

@thomthom
Copy link
Contributor Author

No worries. Fully understand the time constraints.

Since realising that I can refer to git for gems in Gemfile I've been able to easily set up patch branches in my own fork while PRs are pending.

lsegal added a commit that referenced this pull request Apr 2, 2019
@lsegal
Tag release v0.9.19
12f56cf 
References:
  #1071, #1198, #1219, #1226, #1228, #1229, #1231, #1233,
  #1234, #1235
@thomthom thomthom deleted the dev-fix-anchor-history branch April 9, 2019 18:48
@dependabot dependabot bot mentioned this pull request Mar 12, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lsegal lsegal lsegal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thomthom @coveralls @lsegal