resolves #1231 sort README files #1233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 similar comment
|
Tests should succeed after merging #1234 in. |
skalee
reviewed
Mar 30, 2019
lsegal
reviewed
Mar 30, 2019
mojavelinux
force-pushed
the
issue-1231-readme-sorting
branch
from
3915182
to
6d5a359
Compare
|
PR updated as requested. |
mojavelinux
force-pushed
the
issue-1231-readme-sorting
branch
from
6d5a359
to
a0bcaa1
Compare
|
Build is green. |
lsegal
reviewed
Mar 31, 2019
|
Doh! Of course. I'll update.
|
- sort README files, first by file extension, then by basename - prefer README basename over all other files - prefer file without extension over file with extension - don't glob for files if README is missing and files list is empty
mojavelinux
force-pushed
the
issue-1231-readme-sorting
branch
from
a0bcaa1
to
88da7e6
Compare
lsegal
approved these changes
Mar 31, 2019
|
Thanks for working on this! |
|
You're welcome. Glad to help! |
|
Seems as though there are some failures on Windows due to this logic, probably conflicting with Dir.glob on other platforms. I'm looking into this now. |
lsegal
added a commit
that referenced
this pull request
Apr 1, 2019
|
That's very unexpected. I'll be interested to hear what you find. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The main reason for this change is to choose the README that users most expect to be chosen. Currently, there isn't really any rhyme or reason to which README is selected because the files aren't explicitly sorted. With this change, README will be selected over README.md, and README.md will be selected over README-zh_CN.md (or README.zh_CN.md).
The changes included are:
Completed Tasks
bundle exec rakelocally (if code is attached to PR).