Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for trunk as of svn 60140 2017-10-08 #1124

Merged
merged 1 commit into from
Oct 16, 2017

Conversation

MSP-Greg
Copy link
Contributor

@MSP-Greg MSP-Greg commented Oct 8, 2017

Description

Two new failures occur with ruby 2.5.0dev (2017-10-08 trunk 60140) [x64-mingw32].

The first, in ast_node.rb, is detailed in https://bugs.ruby-lang.org/issues/12387.

The second, in specification.rb, is due to @@default_value being frozen.

With these two changes, and some fixes over in ruby/ruby, trunk passes all tests locally.

Completed Tasks

  • I have read the Contributing Guide.
  • The pull request is complete (implemented / written).
  • Git commits have been cleaned up (squash WIP / revert commits).
  • I wrote tests and ran bundle exec rake locally (if code is attached to PR).

@coveralls
Copy link

coveralls commented Oct 8, 2017

Coverage Status

Coverage decreased (-0.01%) to 93.498% when pulling 2142516 on MSP-Greg:trunk_fixes into c546a8a on lsegal:master.

@lsegal lsegal merged commit f180935 into lsegal:master Oct 16, 2017
lsegal added a commit that referenced this pull request Nov 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants