Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

css fix for inline code #1142

Merged
merged 1 commit into from
Nov 22, 2017
Merged

css fix for inline code #1142

merged 1 commit into from
Nov 22, 2017

Conversation

noraj
Copy link

@noraj noraj commented Nov 20, 2017

Description

See Better highlight of inline code

Completed Tasks

  • I have read the Contributing Guide.
  • The pull request is complete (implemented / written).
  • Git commits have been cleaned up (squash WIP / revert commits).
  • I wrote tests and ran bundle exec rake locally (if code is attached to PR).

@noraj noraj mentioned this pull request Nov 20, 2017
Closed
@noraj
Copy link
Author

noraj commented Nov 20, 2017

See issue #1141

@coveralls
Copy link

Coverage Status

Coverage remained the same at 93.502% when pulling cedc0a5 on noraj1337:patch-1 into 9fcfe09 on lsegal:master.

1 similar comment
@coveralls
Copy link

coveralls commented Nov 20, 2017 •
edited
Loading

Coverage Status

Coverage remained the same at 93.502% when pulling cedc0a5 on noraj1337:patch-1 into 9fcfe09 on lsegal:master.

lsegal
lsegal approved these changes Nov 20, 2017
View reviewed changes
Copy link
Owner

@lsegal lsegal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I need to verify that this doesn't break some of the markup parsers-- I believe I've seen cases where we have a similar border padding.

That said, this looks good to me.

@lsegal lsegal merged commit bd56c5d into lsegal:master Nov 22, 2017
lsegal added a commit that referenced this pull request Nov 23, 2017
@lsegal
Tag release v0.9.11
7748eda 
References:
  #1139, #1142, #1143
@noraj noraj deleted the patch-1 branch December 29, 2017 23:59
noraj pushed a commit to noraj/yard that referenced this pull request Dec 30, 2017
css fix for inline code
898e7b6 
fix PR lsegal#1142

see comment lsegal#1141 (comment)
@noraj noraj mentioned this pull request Dec 30, 2017
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lsegal lsegal lsegal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@noraj @coveralls @lsegal