Conditional include for openssl engines #828
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi Guys, If you agree with this, I will make the same for master branch. Tom |
|
Probably it's better to check for OPENSSL_NO_ENGINE. Or both. |
thalman
force-pushed
the
opensslengine_12
branch
2 times, most recently
from
f44532f
to
745de36
Compare
|
I updated the condition according other places in source code. I now checks both |
thalman
force-pushed
the
opensslengine_12
branch
from
2e3f4ca
to
032602a
Compare
|
Checking API version was bad idea. It does not work with older openssl libraries correctly. Removed. |
lsh123
requested changes
Jul 29, 2024
thalman
force-pushed
the
opensslengine_12
branch
from
3b2fdab
to
57e7e5e
Compare
|
I believe that the condition is correct now. Tom |
|
yep, looks great! Thanks for catching it and working on multiple iterations of the fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
xmlsec can't be compiled on systems where openss/engine.h is missing. In some distributions this file is in extra package (Fedora) or not present at all.
This update makes the include conditional based on
configureoption--enable_openssl3_engines.