Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker multistage #48

Merged
merged 172 commits into from
Oct 13, 2020
Merged

Docker multistage #48

merged 172 commits into from
Oct 13, 2020

Conversation

lskatz
Copy link
Owner

@lskatz lskatz commented Oct 13, 2020

What type of PR is this?

Fixing the Dockerfile

Describe the change

The Docker build goes from a huge monolith to a multistage approach.
This saves in time and hard drive space.

Does it change the usage of SneakerNetPlugins.pl?

No

Did you add any unit testing? Please describe

Yes, in GitHub Actions: https://github.com/lskatz/SneakerNet/runs/1244651937?check_suite_focus=true

lskatz and others added 29 commits October 2, 2020 17:18
```
#130 [linux/386 stage-11 34/47] RUN pip3 install poetry &&  git clone https:/...
#130 11.73   building '_openssl' extension
#130 11.73   creating build/temp.linux-x86_64-3.6/build
#130 11.73   creating build/temp.linux-x86_64-3.6/build/temp.linux-x86_64-3.6
#130 11.73   i686-linux-gnu-gcc -pthread -DNDEBUG -g -fwrapv -O2 -Wall -g -fstack-protector-strong -Wformat -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -fPIC -I/usr/include/python3.6m -c build/temp.linux-x86_64-3.6/_openssl.c -o build/temp.linux-x86_64-3.6/build/temp.linux-x86_64-3.6/_openssl.o -Wconversion -Wno-error=sign-conversion
#130 11.73   build/temp.linux-x86_64-3.6/_openssl.c:50:14: fatal error: pyconfig.h: No such file or directory
#130 11.73    #    include <pyconfig.h>
#130 11.73                 ^~~~~~~~~~~~
#130 11.73   compilation terminated.
#130 11.73   error: command 'i686-linux-gnu-gcc' failed with exit status 1
#130 11.73   ----------------------------------------
#130 11.73   ERROR: Failed building wheel for cryptography
#130 11.73 Failed to build cryptography
#130 11.74 ERROR: Could not build wheels for cryptography which use PEP 517 and cannot be installed directly
#130 ERROR: executor failed running [/bin/sh -c pip3 install poetry &&  git clone https://github.com/hcdenbakker/SalmID.git --branch 0.1.23 --single-branch &&  cd SalmID &&  poetry build -vvv &&  pip3 install dist/salmid*.whl]: buildkit-runc did not terminate successfully
```
@lskatz lskatz merged commit bb9c56e into master Oct 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant