DM-43638: Update to technote 0.8 to fix baseline alignment for monospace text in technotes #225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is for investigating the baseline alignment issue in Safari.
This change fixes the baseline misalignment for monospace text in technotes.
jonathansick
force-pushed
the
tickets/DM-43638
branch
from
f7f2b98
to
bae8534
Compare
With technote 0.8, the font size on the html element is again 100%, so the rem is effectively smaller. This change to ems makes these new sizes relative to the body font size, which is 1.1 rem.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fixes the baseline misalignment for monospace text in technotes.