Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add LibraryTypes #409

Merged
merged 1 commit into from
Sep 21, 2024
Merged

add LibraryTypes #409

merged 1 commit into from
Sep 21, 2024

Conversation

folkertdev
Copy link
Contributor

why use vectors of strings when two booleans will do.

src/build.rs Outdated Show resolved Hide resolved
src/build_targets.rs Outdated Show resolved Hide resolved
src/build.rs Outdated Show resolved Hide resolved
@lu-zero
Copy link
Owner

lu-zero commented Sep 11, 2024

we shouldn't have additional library types to deal with so it should be fine to use two booleans, the string were inherited from how cargo dealt with that.

src/build.rs Show resolved Hide resolved
Copy link
Owner

@lu-zero lu-zero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@lu-zero lu-zero merged commit db1dbab into lu-zero:master Sep 21, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants