Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support username change #144

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Conversation

binkoni
Copy link
Contributor

@binkoni binkoni commented Apr 27, 2019

Added username change support

@binkoni
Copy link
Contributor Author

binkoni commented Nov 20, 2019

Hmm.. no plan to support this?

@leafo
Copy link
Collaborator

leafo commented Nov 20, 2019

sorry, I must have missed this pull request. Looking over it

@leafo
Copy link
Collaborator

leafo commented Nov 20, 2019

Changing usernames can break URLs to manifests & packages.

  • Minimally we should have a big warning about changing your username, explaining why it might not be a good idea
  • We can set up an automatic redirect for the old username to the new username (both for profile pages, and manifest/package urls)
    • A new model would need to be created, UserRedirects or something similar
  • On other sites where I've implemented username changing, I tend to keep the old username locked. This means preventing an account using a previously used username to stop hijacking any old URLs. I think this is especially important for a package manager.

@binkoni
Copy link
Contributor Author

binkoni commented Nov 23, 2019

@leafo Thanks for the response. Since it seems to take some time, I'll implement what you said when I have some time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants