[DRAFT] Use dosnames in M23 commands for Marlin
#344
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Marlin merged this PR MarlinFirmware/Marlin#23526 for M23 long name support |
|
and I tested it was working #221 (comment) I wont recommend to workaround a broken feature , better fix the feature in Marlin |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Marlin requires short 8.3 DOS names for all file handling commands.
When Marlin uses MKS Serial protocol files are always listed with dosnames only, even with
M20 Lcommand. In order to support displaying long filenames and be able to print them ESP3D-WEBUI has to use both reported filenames: short one for issuing Print and Delete commands, and long ones, when available, to nicely display in file list panel.This is draft PR that has not yet been tested.