Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to v2 #14

Merged
merged 4 commits into from
Jun 16, 2021
Merged

Upgrade to v2 #14

merged 4 commits into from
Jun 16, 2021

Conversation

rlindskog
Copy link
Contributor

@rlindskog rlindskog commented Aug 21, 2020

Addresses #13

Deployed example - https://graphql-pokemon2.vercel.app

Run locally with vercel dev to test.

This was referenced Aug 24, 2020
@@ -41,7 +41,7 @@
"repository": "https://github.com/lucasbento/graphql-pokemon",
"scripts": {
"eslint": "eslint src/*",
"build": "rm -rf dist/* && babel src --out-dir dist --copy-files",
"build-app": "rm -rf dist/* && babel src --out-dir dist --copy-files",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this change is not very clear

@@ -55,7 +55,7 @@ query {

```sh
yarn
yarn run build
yarn run build-app
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

here as well


or

vercel dev # npm i -g @now/cli
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
vercel dev # npm i -g @now/cli
vercel dev # npm i -g vercel

@leerob
Copy link

leerob commented Sep 12, 2020

I'd love to see this merged! Was looking for a Pokemon GQL API today 😄

jaydenseric added a commit to jaydenseric/graphql-react-examples that referenced this pull request Sep 17, 2020
@kfnx
Copy link

kfnx commented Oct 9, 2020

Which part of the changes that update to use the pokeAPI to work with v2?

@carloslibardo
Copy link

Why don't be merged yet? For me it's right ;)

kodiakhq bot pushed a commit to vercel/next.js that referenced this pull request Jun 10, 2021
## Documentation / Examples

- [x] Make sure the linting passes

As mentioned in #25854 `with-urql` doesn't work. After investigation, I've found that Pokémon GraphQL server located at `https://graphql-pokemon.vercel.app` is down.
After some research I came across its repository and this [pull request](lucasbento/graphql-pokemon#14). That pull request provides new URL `https://graphql-pokemon2.vercel.app` which seems to work.

I don't know the status of this server, maybe @leerob can confirm this PR is ok.
@leerob
Copy link

leerob commented Jun 10, 2021

Hey! Any update here? We're seen some issues from folks referencing this URL as it's now broken.

If this project is deprecated, let me know and we can reassign the URL 👍

janicklas-ralph pushed a commit to janicklas-ralph/next.js that referenced this pull request Jun 11, 2021
## Documentation / Examples

- [x] Make sure the linting passes

As mentioned in vercel#25854 `with-urql` doesn't work. After investigation, I've found that Pokémon GraphQL server located at `https://graphql-pokemon.vercel.app` is down.
After some research I came across its repository and this [pull request](lucasbento/graphql-pokemon#14). That pull request provides new URL `https://graphql-pokemon2.vercel.app` which seems to work.

I don't know the status of this server, maybe @leerob can confirm this PR is ok.
@lucasbento lucasbento merged commit ac1a3b4 into lucasbento:master Jun 16, 2021
@lucasbento
Copy link
Owner

@leerob: merged, thank you so much for doing this and I'm very very sorry for not looking into it sooner.

flybayer pushed a commit to blitz-js/next.js that referenced this pull request Jun 16, 2021
## Documentation / Examples

- [x] Make sure the linting passes

As mentioned in vercel#25854 `with-urql` doesn't work. After investigation, I've found that Pokémon GraphQL server located at `https://graphql-pokemon.vercel.app` is down.
After some research I came across its repository and this [pull request](lucasbento/graphql-pokemon#14). That pull request provides new URL `https://graphql-pokemon2.vercel.app` which seems to work.

I don't know the status of this server, maybe @leerob can confirm this PR is ok.
tuannyharumi added a commit to tuannyharumi/artemis that referenced this pull request Jun 17, 2021
The old API was down and it was moved to this new endpoint lucasbento/graphql-pokemon#14
Also updates build_runner version to avoid incompatible version with artemis
tuannyharumi added a commit to tuannyharumi/artemis that referenced this pull request Jun 17, 2021
The old API was down and it was moved to this new endpoint lucasbento/graphql-pokemon#14
Also updates build_runner version to avoid incompatible version with artemis
tuannyharumi added a commit to tuannyharumi/artemis that referenced this pull request Jun 18, 2021
The old API was down and it was moved to this new endpoint lucasbento/graphql-pokemon#14
Also updates build_runner version to avoid incompatible version with artemis
JulianHartl pushed a commit to SelectCode/artemis that referenced this pull request Jan 13, 2023
The old API was down and it was moved to this new endpoint lucasbento/graphql-pokemon#14
Also updates build_runner version to avoid incompatible version with artemis
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants