double check existence before throwing an exception

lucee · Oct 8, 2024 · 8495e7a · 8495e7a
1 parent 864dc92
commit 8495e7a
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 3 deletions.
diff --git a/core/src/main/java/lucee/commons/io/res/type/file/FileResource.java b/core/src/main/java/lucee/commons/io/res/type/file/FileResource.java
@@ -263,7 +263,9 @@ public OutputStream getOutputStream(boolean append) throws IOException {
 		provider.lock(this);
 		try {
 			if (!super.exists() && !super.createNewFile()) {
-				throw new IOException("Can't create file [" + this + "]");
+				// It's possible that another process (outside this JVM) has already created the file
+				// after our initial check, so we perform a double check before throwing an exception.
+				if (!super.exists()) throw new IOException("Can't create file [" + this + "]");
 			}
 			return new BufferedOutputStream(new ResourceOutputStream(this, new FileOutputStream(this, append)));
 		}

diff --git a/loader/build.xml b/loader/build.xml
@@ -2,7 +2,7 @@
 <project default="core" basedir="." name="Lucee" 
   xmlns:resolver="antlib:org.apache.maven.resolver.ant">
 
-  <property name="version" value="6.0.4.9-SNAPSHOT"/>
+  <property name="version" value="6.0.4.10-SNAPSHOT"/>
 
   <taskdef uri="antlib:org.apache.maven.resolver.ant" resource="org/apache/maven/resolver/ant/antlib.xml">
     <classpath>

diff --git a/loader/pom.xml b/loader/pom.xml
@@ -3,7 +3,7 @@
 
   <groupId>org.lucee</groupId>
   <artifactId>lucee</artifactId>
-  <version>6.0.4.9-SNAPSHOT</version>
+  <version>6.0.4.10-SNAPSHOT</version>
   <packaging>jar</packaging>
 
   <name>Lucee Loader Build</name>