Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "No brands" and "Not too specific" rules in Icon Design Guide #1336

Closed
airone01 opened this issue Jun 5, 2023 · 2 comments
Closed

Add "No brands" and "Not too specific" rules in Icon Design Guide #1336

airone01 opened this issue Jun 5, 2023 · 2 comments

Comments

@airone01
Copy link
Contributor

airone01 commented Jun 5, 2023

Today I made some icons for cryptocurrencies and posted an Issue, then a PR here.
It's my bad that I didn't read #670 but since the decision was taken one year ago, I would have expected to see it in the rules.

There is the question of icons that are too specific as well. Are they avoided because it's too much work or because they're banned ?

I like the icon, but the icon is too specific. The use case for pastry shops is kinda covered by the croissant icon.

It would save time to new contributors such as myself to add these two rules to the icon design guide:

- Icons must not be branded (link to #670)
- Icons uses must not be too specific

Btw I love this project and have been using your icons for a while now. They saved me a lot of time.
Thanks a bunch!

@jguddas
Copy link
Member

jguddas commented Jun 5, 2023

Yes, this is super important!

Here is my WIP collection of stuff that should be included in the contribution guidelines #1224 (comment)

Getting this all into an understandable format will be quite an undertaking, any help much appreciated ❤️

@airone01 airone01 mentioned this issue Jun 5, 2023
26 tasks
@airone01
Copy link
Contributor Author

airone01 commented Jun 5, 2023

Debate on #1224. Closing.

@airone01 airone01 closed this as completed Jun 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants