Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Icon Requests from Feather] walking #609

Open
karsa-mistmere opened this issue Apr 22, 2022 · 6 comments
Open

[Icon Requests from Feather] walking #609

karsa-mistmere opened this issue Apr 22, 2022 · 6 comments
Assignees

Comments

@karsa-mistmere
Copy link
Member

As per #119 and feathericons/feather#471:

image
walking

@ericfennis
Copy link
Member

I think this one should be matching person-standing.

@karsa-mistmere
Copy link
Member Author

This redesign would make it have the same dimensions, but at the same time, it makes the walking person look comically short compared to the standing person (partly because of the slight guideline violations in case of the shoulders of person-standing):

image
image

Moving this icons shoulders 1px closer to its head kind of solves this issue, but also violates the design guidelines:
image

Not sure, what the best approach would be. Maybe person-standing also needs a redesign.

@karsa-mistmere
Copy link
Member Author

karsa-mistmere commented May 5, 2022

@ericfennis Come to think of it, walking should definitely also match bike, since they're likely to be used together.
image

Problem is, bike itself - neat as it is - breaks a handful of our current guidelines. 😅
I think the reality is, the body parts of these ISO DOT style pictograms should probably be exempt from the 2px spacing rule, since they look much better with about a 1-1.5px spacing even on low dpi.

Here's what I think would be a harmonization of different transport icons (blue: existing and should be kept, red: existing and should be fixed, green: new icons):
image
transport

I'm not totally sure if bike really needs "fixing", it's pretty OK on low dpi, although it does look a bit wonky at 3px:
image

Edit: icons for trolleybus, an alternate (school?)bus, subway and ship:
image
image

@ericfennis
Copy link
Member

@karsa-mistmere Nice work on the icons, I think the icons you bordered with green are great, except for the bike and the truck-front icons. I think some paths looks a bit too dense. But I understand those are hard one to design. I can give it a shot as well.

For the person icons:

I see we violate some guidelines for example the head of the person. But applying the 2px spacing on all the "person" icons will result that the head looks a bit detached of the body. So I'm fine make an exception for this one and do 1px spacing.

@kemie
Copy link
Contributor

kemie commented Oct 20, 2022

I propose rethinking the full-body humans to make them more dimensional, less slim, and match user/person icons better. I went with the consensus of making an exception to the 2px gap rule but still works reasonably well at 3px
new icons proposal:
illustrator_template ai2 @ 1600  (RGBPreview)   2022-10-20 at 135515@2x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants