-
-
Notifications
You must be signed in to change notification settings - Fork 516
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add transport icons #1412
Add transport icons #1412
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok I think it's time to prioritize the list a bit. This PR is also getting bigger and bigger.
Overal the designs are really good!
To merge this I accept the following icons for this PR. I wrote some notes for the icons I rejected for now, if you don't agree with some of my notes. Please consider opening new issue or discussion to discuss this. So we can merge this one for now.
- bus-school-front, I think the design is too similar to
coach-front
. Probably for the use case of this,coach-front
will do the job fine. - bus
- cable-car
- car-electric-front, The use case of this icon is really good. I like to see a separate issue with some more variations for this one, because I think this deserves some more exploration.
- car-front
- car-sports-front, not sure about the design and the use case. Maybe a bit too specific.
- car-taxi-front
- car
- coach-front-2, One icon of this one is fine
- coach-front, maybe call this
bus-front
? - m-square
- parking-meter
- rail-symbol
- ship-wheel
- tractor
- traffic-cone
- train-front-tunnel, not sure about the use case.
- train-front
- train-track
- tram-front
- truck
@ericfennis Ok, made most of those changes, and moved the others to a separate PR for discussion…
Maps, for one… |
Yes, to signify subways in trip planning / public transport schedule apps, I thought this would be a no brainer to add. 😅 |
@karsa-mistmere True but it doesn't look like a subway icon, more a highspeed train in a tunnel. |
@ericfennis It can be either :) |
car-*
alts:See also #1460.