Feather icon requests #114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
locness3
approved these changes
Oct 30, 2020
|
Awesome work! Nice to have this overview. |
|
@ericfennis You are probably right. Would be easier to update and maintain that way. Maybe still a link to it in the contribution guidelines? |
|
I think also nice that you can also reference the issue when making a PR. |
|
I'll create an issue and revert the FEATHER_ICON_REQUESTS.md commits in this PR. |
|
That should be it. |
ericfennis
reviewed
Oct 31, 2020
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds FEATHER_ICON_REQUESTS.md which contains a table with open Feather icon requests that have not been implemented in Lucide and do not contain any branded logos. I put the file in the docs folder but maybe it should be placed somewhere else.
I also added a section in the contribution guidelines about the Feather icon requests.