Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add handle-down-right icon #1793

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

ocavue
Copy link
Contributor

@ocavue ocavue commented Jan 10, 2024

What is the purpose of this pull request?

  • New Icon
  • Bug fix
  • New Feature
  • Documentation update
  • Other:

Description

This PR adds a new handle-down-right icon, shown below.

image

Icon use case

This is to represent a resize handle at the bottom right corner of a resizable object (e.g. <textarea>). (For this reason, this icon is not centered).

Browsers would display two (or more, depending on the browser) slashes for CSS resize rule.

Alternative icon designs

image

Icon Design Checklist

Concept

  • I have provided valid use cases for each icon.
  • I have not added any a brand or logo icon.
  • I have not used any hate symbols.
  • I have not included any religious or political imagery.

Author, credits & license

Naming

  • I've read and followed the naming conventions
  • I've named icons by what they are rather than their use case.
  • I've provided meta JSON files in icons/[iconName].json.

Design

  • I've read and followed the icon design guidelines
  • I've made sure that the icons look sharp on low DPI displays.
  • I've made sure that the icons look consistent with the icon set in size, optical volume and density.
  • I've made sure that the icons are visually centered.
  • I've correctly optimized all icons to two points of precision.

Before Submitting

@github-actions github-actions bot added 🎨 icon About new icons 🫧 metadata Improved metadata labels Jan 10, 2024
Copy link

github-actions bot commented Jan 10, 2024

Added or changed icons

icons/handle-down-right.svg

Preview cohesion icons/key-square.svg
icons/handle-down-right.svg
icons/arrow-down-up.svg
Preview stroke widths icons/handle-down-right.svg
icons/handle-down-right.svg
icons/handle-down-right.svg
DPI Preview (24px) icons/handle-down-right.svg
Icon X-rays icons/handle-down-right.svg
Icon Diffs icons/handle-down-right.svg
Icons as code

Works for: lucide-react, lucide-react-native, lucide-preact, lucide-vue-next

const HandleDownRightIcon = createLucideIcon('HandleDownRight', [
  ["path",{"d":"M21 8 8 21"}],
  ["path",{"d":"m21 15-6 6"}]
])

Copy link
Member

@jguddas jguddas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Icon is not visually centered
  • Name describes usecase rather than content

@ocavue
Copy link
Contributor Author

ocavue commented Jan 11, 2024

Icon is not visually centered

I think this icon looks better when it's not centered. However, if the visual center is so important, we could consider handle-down-right-alt-4 or handle-down-right-alt-5 in the PR description.

Name describes usecase rather than content

What's your recommendation about the naming? Here are some alternative names I can think of:

  • angle-down-right
  • slash-slash

@karsa-mistmere karsa-mistmere mentioned this pull request Feb 1, 2024
5 tasks
@damien-schneider
Copy link

damien-schneider commented Feb 2, 2024

In my opinion, 'handle-down-right' is more intuitive. In the Phosphor library, it is named 'notche,' but I find this less intuitive.

Regarding the positioning, I don't have a strong opinion. As for the number of slashes, I believe that 2 is much better and more in line with the spirit of the library.

@github-actions github-actions bot added the Stale label Mar 7, 2024
@lucide-icons lucide-icons deleted a comment from github-actions bot Mar 29, 2024
@ericfennis ericfennis removed the Stale label Mar 29, 2024
@ericfennis
Copy link
Member

@jguddas I think looking at the usecase of this icon, I think positioning it centered makes it hard to use this icon.

For example, if you want to position it with CSS, it is intuitive to use it like this:

.icon-handle-down-right {
  position: absolute;
  bottom: 0;
  right: 0;
}

If we center this, you need to pixel-position it. Which is annoying from DX point of view. We had a related discussion before with all the signal icons. We decided to prefer DX over the guidelines.

For naming, we like to use generic names for what it represents.
But not sure what generic names we should use for this. Since it is hard to for two little lines. I can imagine we want to have other variants as well for other corners.
Since it represents "grip lines" I think grip-lines-right-down will work.

@jguddas
Copy link
Member

jguddas commented Mar 29, 2024

I'm against adding this.

@damien-schneider
Copy link

damien-schneider commented Mar 29, 2024

I'm against adding this.

I'm using lucid for a SaaS, and the only icon I still need to have an other library (making it non-consistent) is this one, so this icon is needed, really....

@karsa-mistmere
Copy link
Member

I agree with @ericfennis and I'm okay with adding this as either grip-lines-right-down, grip-lines-bottom-right or grip-lines-sw.

@ericfennis
Copy link
Member

Not sure why @jguddas is against it. It has a valid use case. And seems like a nice addition next to the current grip icons.

@jguddas jguddas closed this Nov 1, 2024
@damien-schneider
Copy link

I really don't understand why it has been close, this icon has a real use case and is missing to the lib, very sad that it hasn't been implemented 😕

@jguddas jguddas reopened this Nov 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎨 icon About new icons 🫧 metadata Improved metadata
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants