-
-
Notifications
You must be signed in to change notification settings - Fork 505
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add handle-down-right
icon
#1793
base: main
Are you sure you want to change the base?
Conversation
Added or changed iconsIcons as codeWorks for: const HandleDownRightIcon = createLucideIcon('HandleDownRight', [
["path",{"d":"M21 8 8 21"}],
["path",{"d":"m21 15-6 6"}]
]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Icon is not visually centered
- Name describes usecase rather than content
I think this icon looks better when it's not centered. However, if the visual center is so important, we could consider
What's your recommendation about the naming? Here are some alternative names I can think of:
|
In my opinion, 'handle-down-right' is more intuitive. In the Phosphor library, it is named 'notche,' but I find this less intuitive. Regarding the positioning, I don't have a strong opinion. As for the number of slashes, I believe that 2 is much better and more in line with the spirit of the library. |
@jguddas I think looking at the usecase of this icon, I think positioning it centered makes it hard to use this icon. For example, if you want to position it with CSS, it is intuitive to use it like this: .icon-handle-down-right {
position: absolute;
bottom: 0;
right: 0;
} If we center this, you need to pixel-position it. Which is annoying from DX point of view. We had a related discussion before with all the For naming, we like to use generic names for what it represents. |
I'm against adding this. |
I'm using lucid for a SaaS, and the only icon I still need to have an other library (making it non-consistent) is this one, so this icon is needed, really.... |
I agree with @ericfennis and I'm okay with adding this as either |
Not sure why @jguddas is against it. It has a valid use case. And seems like a nice addition next to the current |
I really don't understand why it has been close, this icon has a real use case and is missing to the lib, very sad that it hasn't been implemented 😕 |
What is the purpose of this pull request?
Description
This PR adds a new
handle-down-right
icon, shown below.Icon use case
This is to represent a resize handle at the bottom right corner of a resizable object (e.g.
<textarea>
). (For this reason, this icon is not centered).Browsers would display two (or more, depending on the browser) slashes for CSS
resize
rule.Alternative icon designs
Icon Design Checklist
Concept
Author, credits & license
slash
Naming
icons/[iconName].json
.Design
Before Submitting