-
-
Notifications
You must be signed in to change notification settings - Fork 516
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add story
icon
#1820
Add story
icon
#1820
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work @jordan808!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work, LGTM
Co-authored-by: Jakob Guddas <[email protected]>
Co-authored-by: Jakob Guddas <[email protected]>
What about the name? It should be something like https://lucide.dev/guide/design/icon-design-guide#naming-conventions |
I assumed story was already agnostic but you are right that it would have to be changed. In this case, it should also be included in the "shapes" category. Your suggestion would also follow the conventions of the other dashed circles like Should I update the name and category? |
I think @jguddas is talking about naming convention no. 3:
I don't know, I feel like this might be a bit misleading, as if the plus itself was tapered and/or dashed. How about
|
Ahh good point @karsa-mistmere ! Do you have a preference? I like the idea of |
What is the purpose of this pull request?
Description
Adds
story
icon as requested by #119. Closes feather icons issue feathericons/feather#1019.Icon use case
The purpose of this icon is to represent stories, as popularized by Snapchat and Instagram. Use cases include referencing, or enabling users to create their own stories in an app, or for a digital marketing platform that automates the posting of stories as a feature.
Alternative icon designs
Icon Design Checklist
Concept
Author, credits & license
Naming
icons/[iconName].json
.Design
Before Submitting