Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add story icon #1820

Merged
merged 8 commits into from
Jan 30, 2024
Merged

Add story icon #1820

merged 8 commits into from
Jan 30, 2024

Conversation

jordan808
Copy link
Contributor

What is the purpose of this pull request?

  • New Icon
  • Bug fix
  • New Feature
  • Documentation update
  • Other:

Description

Adds story icon as requested by #119. Closes feather icons issue feathericons/feather#1019.

Icon use case

The purpose of this icon is to represent stories, as popularized by Snapchat and Instagram. Use cases include referencing, or enabling users to create their own stories in an app, or for a digital marketing platform that automates the posting of stories as a feature.

Alternative icon designs

story-alt

Icon Design Checklist

Concept

  • I have provided valid use cases for each icon.
  • I have not added any a brand or logo icon.
  • I have not used any hate symbols.
  • I have not included any religious or political imagery.

Author, credits & license

  • The icons are solely my own creation.
  • The icons were originally created in # by @
  • I've based them on the following Lucide icons:
  • I've based them on the following design: The Instagram stories icon as seen in the app under story settings ->
    IMG_0300

Naming

  • I've read and followed the naming conventions
  • I've named icons by what they are rather than their use case.
  • I've provided meta JSON files in icons/[iconName].json.

Design

  • I've read and followed the icon design guidelines
  • I've made sure that the icons look sharp on low DPI displays.
  • I've made sure that the icons look consistent with the icon set in size, optical volume and density.
  • I've made sure that the icons are visually centered.
  • I've correctly optimized all icons to two points of precision.

Before Submitting

@github-actions github-actions bot added 🎨 icon About new icons 🫧 metadata Improved metadata labels Jan 21, 2024
Copy link

github-actions bot commented Jan 21, 2024

Added or changed icons

icons/circle-fading-plus.svg

Preview cohesion icons/chevron-right-square.svg
icons/circle-fading-plus.svg
icons/candy.svg
Preview stroke widths icons/circle-fading-plus.svg
icons/circle-fading-plus.svg
icons/circle-fading-plus.svg
DPI Preview (24px) icons/circle-fading-plus.svg
Icon X-rays icons/circle-fading-plus.svg

Copy link
Member

@ericfennis ericfennis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work @jordan808!

icons/story.svg Outdated Show resolved Hide resolved
@ericfennis ericfennis mentioned this pull request Jan 21, 2024
7 tasks
Copy link
Member

@ericfennis ericfennis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, LGTM

icons/story.svg Outdated Show resolved Hide resolved
icons/story.json Outdated Show resolved Hide resolved
@jguddas
Copy link
Member

jguddas commented Jan 23, 2024

What about the name?

It should be something like circle-plus-tapered-dash.

https://lucide.dev/guide/design/icon-design-guide#naming-conventions

@jordan808
Copy link
Contributor Author

What about the name?

It should be something like circle-plus-tapered-dash.

https://lucide.dev/guide/design/icon-design-guide#naming-conventions

I assumed story was already agnostic but you are right that it would have to be changed. In this case, it should also be included in the "shapes" category. Your suggestion would also follow the conventions of the other dashed circles like circle-dot-dashed: circle-dot-dashed

Should I update the name and category?

@karsa-mistmere
Copy link
Member

I assumed story was already agnostic but you are right that it would have to be changed.

I think @jguddas is talking about naming convention no. 3:

Icons should be named for what they depict rather than their use case or what they represent.

circle-plus-tapered-dash

I don't know, I feel like this might be a bit misleading, as if the plus itself was tapered and/or dashed.

How about circle-[adjective]-plus, [adjective] being one of these?

  • 😄 fading
  • 🎉 dissolving
  • 😕 tapering
  • ❤️ vanishing
  • 🚀 diminishing
  • 👀 dissipating

@jordan808
Copy link
Contributor Author

Ahh good point @karsa-mistmere ! Do you have a preference? I like the idea of circle-fading-plus

@karsa-mistmere karsa-mistmere merged commit a5221c2 into lucide-icons:main Jan 30, 2024
5 checks passed
@jordan808 jordan808 deleted the icon/story branch January 30, 2024 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎨 icon About new icons 🫧 metadata Improved metadata
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants