Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add battery icons #23

Merged
merged 6 commits into from
Jun 26, 2020
Merged

feat: Add battery icons #23

merged 6 commits into from
Jun 26, 2020

Conversation

johnletey
Copy link
Collaborator

localhost_3000__query=battery

Closes #22

@ericfennis
Copy link
Member

Nice work, looks great! 🔥🔥🔥

@ericfennis
Copy link
Member

maybe refactor the code with some basic svg elements instead of paths.

@johnletey
Copy link
Collaborator Author

@ericfennis I'm not that familiar with SVG elements 😅 So I won't be able to do this very easily

@ericfennis
Copy link
Member

I can help you, no problem. I will make some suggestions.

@johnletey
Copy link
Collaborator Author

@ericfennis Would love that 👍

Copy link
Member

@ericfennis ericfennis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

voila

icons/battery-charging.svg Outdated Show resolved Hide resolved
icons/battery-full.svg Outdated Show resolved Hide resolved
icons/battery-low.svg Outdated Show resolved Hide resolved
icons/battery-medium.svg Outdated Show resolved Hide resolved
icons/battery.svg Outdated Show resolved Hide resolved
@johnletey
Copy link
Collaborator Author

@ericfennis That's amazing! Thank you so much ❤️ Suggestions applied.

@johnletey johnletey merged commit cb5d712 into master Jun 26, 2020
@johnletey johnletey deleted the feat/battery branch June 26, 2020 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Icon request: intermediate battery levels
2 participants