Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/gender icons #2363

Closed
wants to merge 7 commits into from
Closed

Feat/gender icons #2363

wants to merge 7 commits into from

Conversation

Trukl
Copy link

@Trukl Trukl commented Aug 8, 2024

What is the purpose of this pull request?

  • New Icon
  • Bug fix
  • New Feature
  • Documentation update
  • Other:

Description

Added new basic gender icons (male, female, both) for now

Icon use case

  • form with gender selection
  • display gender on user profile

Alternative icon designs

Icon Design Checklist

Concept

  • I have provided valid use cases for each icon.
  • I have not added any a brand or logo icon.
  • I have not used any hate symbols.
  • I have not included any religious or political imagery.

Author, credits & license

  • The icons are solely my own creation.
  • The icons were originally created in # by @
  • I've based them on the following Lucide icons:
  • I've based them on the following design:

Naming

  • I've read and followed the naming conventions
  • I've named icons by what they are rather than their use case.
  • I've provided meta JSON files in icons/[iconName].json.

Design

  • I've read and followed the icon design guidelines
  • I've made sure that the icons look sharp on low DPI displays.
  • I've made sure that the icons look consistent with the icon set in size, optical volume and density.
  • I've made sure that the icons are visually centered.
  • I've correctly optimized all icons to three points of precision.

Before Submitting

Copy link

github-actions bot commented Aug 8, 2024

Added or changed icons

icons/gender-ambiguous.svgicons/gender-female.svgicons/gender-male.svgicons/gender-neuter.svgicons/gender-trans.svg

Preview cohesion icons/square-pi.svgicons/square-chevron-up.svgicons/square-code.svgicons/square-arrow-up-left.svgicons/square-divide.svg
icons/gender-ambiguous.svgicons/gender-female.svgicons/gender-male.svgicons/gender-neuter.svgicons/gender-trans.svg
icons/gallery-vertical.svgicons/folder-open-dot.svgicons/git-compare-arrows.svgicons/heading-5.svgicons/file-cog.svg
Preview stroke widths icons/gender-ambiguous.svgicons/gender-female.svgicons/gender-male.svgicons/gender-neuter.svgicons/gender-trans.svg
icons/gender-ambiguous.svgicons/gender-female.svgicons/gender-male.svgicons/gender-neuter.svgicons/gender-trans.svg
icons/gender-ambiguous.svgicons/gender-female.svgicons/gender-male.svgicons/gender-neuter.svgicons/gender-trans.svg
DPI Preview (24px) icons/gender-ambiguous.svg icons/gender-female.svg icons/gender-male.svg icons/gender-neuter.svg icons/gender-trans.svg
Icon X-rays icons/gender-ambiguous.svg icons/gender-female.svg icons/gender-male.svg icons/gender-neuter.svg icons/gender-trans.svg
Icons as code

Works for: lucide-react, lucide-react-native, lucide-preact, lucide-vue-next

const GenderAmbiguousIcon = createLucideIcon('GenderAmbiguous', [
  ["path",{"d":"M13 6a5 5 0 0 1 3 9"}],
  ["path",{"d":"M16.5 7.5 22 2"}],
  ["path",{"d":"M17 2h5v5"}],
  ["path",{"d":"M5 20h6"}],
  ["path",{"d":"M8 17v5"}],
  ["path",{"d":"M8.422 13A5 5 0 0 1 8 11"}],
  ["circle",{"cx":"8","cy":"12","r":"5"}]
])

const GenderFemaleIcon = createLucideIcon('GenderFemale', [
  ["path",{"d":"M12 15v7"}],
  ["path",{"d":"M8 19h8"}],
  ["circle",{"cx":"12","cy":"9","r":"6"}]
])

const GenderMaleIcon = createLucideIcon('GenderMale', [
  ["path",{"d":"M13 4h7v7"}],
  ["path",{"d":"M13.5 10.5 20 4"}],
  ["circle",{"cx":"9","cy":"15","r":"6"}]
])

const GenderNeuterIcon = createLucideIcon('GenderNeuter', [
  ["circle",{"cx":"12","cy":"9","r":"6"}],
  ["path",{"d":"M12 15v7"}]
])

const GenderTransIcon = createLucideIcon('GenderTrans', [
  ["path",{"d":"M12 17v5"}],
  ["path",{"d":"M15.5 8.5 22 2"}],
  ["path",{"d":"M17 2h5v5"}],
  ["path",{"d":"m2 2 6.5 6.5"}],
  ["path",{"d":"M2 7V2h5"}],
  ["path",{"d":"m4 9 5-5"}],
  ["path",{"d":"M9 20h6"}],
  ["circle",{"cx":"12","cy":"12","r":"5"}]
])

Copy link
Member

@jguddas jguddas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The lack of inclusive language is a no-go for me.

Do we really want to do this, we have a "no politics" rule for a reason?
My vote is for not adding gender icons.

@Trukl
Copy link
Author

Trukl commented Aug 10, 2024

I don't see how it's political, but whatever.
I admit gender-both may not be the best name
let's add the other genders then, if that's the problem

Comment on lines 1 to 20
<svg xmlns="http://www.w3.org/2000/svg"
width="24"
height="24"
viewBox="0 0 24 24"
fill="none"
stroke="currentColor"
stroke-width="2"
stroke-linecap="round"
stroke-linejoin="round">
<path d="M16 1H20C20.5523 1 21 1.44772 21 2V6" />
<path d="M1 6L1 2C1 1.44772 1.44772 1 2 1L6 1" />
<path d="M15 7L20.5 1.5" />
<path d="M1.5 1.5L7 7" />
<circle cx="11" cy="11" r="5" />
<path d="M11 16V21" />
<path d="M8 19H14" />
<path d="M3 7L7 3" />
</svg>


Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does not follow our design guidelines (1px padding, 2px gap between elements).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, I think that since all our current arrows have sharp heads, so should these.

- gender-trans position
@jamiemlaw
Copy link
Contributor

@Trukl you can find some examples of gender icons I designed last week in this thread that abide by the two-pixel-gap rule, if you need inspiration.

I also gave them generic names like venus rather than gender-female, which is in line with what Font Awesome does for theirs.

I have since edited it to leave a note that I wasn't entirely happy with my design for the transgender symbol; and that, any politics aside, getting a workable version of that icon in particular would be one of the prerequisites to adding gender icons as a set to Lucide. So might be worth revisiting that one.

Copy link

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@github-actions github-actions bot added the Stale label Sep 13, 2024
@jguddas jguddas closed this Nov 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎨 icon About new icons 🫧 metadata Improved metadata Stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants