Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(icons): added clock-check icon #2402

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

jguddas
Copy link
Member

@jguddas jguddas commented Aug 24, 2024

related to #2400

What is the purpose of this pull request?

  • New Icon

Description

Added new clock-check icon.

Icon use case

These icons could be used for reflecting input validation, and to indicate delays and such for public transport

Alternative icon designs

Icon Design Checklist

Concept

  • I have provided valid use cases for each icon.
  • I have not added any a brand or logo icon.
  • I have not used any hate symbols.
  • I have not included any religious or political imagery.

Author, credits & license

  • The icons are solely my own creation.
  • The icons were originally created in # by @colebemis
  • I've based them on the following Lucide icons: clock
  • I've based them on the following design:

Naming

  • I've read and followed the naming conventions
  • I've named icons by what they are rather than their use case.
  • I've provided meta JSON files in icons/[iconName].json.

Design

  • I've read and followed the icon design guidelines
  • I've made sure that the icons look sharp on low DPI displays.
  • I've made sure that the icons look consistent with the icon set in size, optical volume and density.
  • I've made sure that the icons are visually centered.
  • I've correctly optimized all icons to three points of precision.

Before Submitting

@github-actions github-actions bot added 🎨 icon About new icons 🫧 metadata Improved metadata labels Aug 24, 2024
Copy link

github-actions bot commented Aug 24, 2024

Added or changed icons

icons/clock-check.svg

Preview cohesion icons/square-user.svg
icons/clock-check.svg
icons/picture-in-picture-2.svg
Preview stroke widths icons/clock-check.svg
icons/clock-check.svg
icons/clock-check.svg
DPI Preview (24px) icons/clock-check.svg
Icon X-rays icons/clock-check.svg
Icon Diffs icons/clock-check.svg
Icons as code

Works for: lucide-react, lucide-react-native, lucide-preact, lucide-vue-next

const ClockCheckIcon = createLucideIcon('ClockCheck', [
  ["path",{"d":"M12 6v6l4 2"}],
  ["path",{"d":"M22 12a10 10 0 1 0-11 9.95"}],
  ["path",{"d":"m22 16-5.5 5.5L14 19"}]
])

@ericfennis
Copy link
Member

Great icon. Also the uses for this.

I think the check should be a bit bigger. On 100% scale it disappears a bit in the rounded shape of the clock, To me on the first view it didn't pop as a check icon.

@jguddas
Copy link
Member Author

jguddas commented Sep 6, 2024

Great icon. Also the uses for this.

I think the check should be a bit bigger. On 100% scale it disappears a bit in the rounded shape of the clock, To me on the first view it didn't pop as a check icon.

This is the standard check icon, we use everywhere.

@karsa-mistmere
Copy link
Member

karsa-mistmere commented Sep 12, 2024

Great icon. Also the uses for this.
I think the check should be a bit bigger. On 100% scale it disappears a bit in the rounded shape of the clock, To me on the first view it didn't pop as a check icon.

This is the standard check icon, we use everywhere.

Maybe we could give the new lucide/12 checkmark a spin?

icons
Open lucide studio

image


Actually, I'd also be in favour of swapping some of our existing checkmarks with this, e.g.:

image

Out of these, copy-check is the only one that uses remains unchanged, and I think, square-check and circle-check look much more balanced and more consistent with copy-check.

@jguddas
Copy link
Member Author

jguddas commented Sep 12, 2024

Great icon. Also the uses for this.
I think the check should be a bit bigger. On 100% scale it disappears a bit in the rounded shape of the clock, To me on the first view it didn't pop as a check icon.

This is the standard check icon, we use everywhere.

Maybe we could give the new lucide/12 checkmark a spin?

iconsOpen lucide studio

image

Actually, I'd also be in favour of swapping some of our existing checkmarks with this, e.g.:

image

Out of these, copy-check is the only one that uses remains unchanged, and I think, square-check and circle-check look much more balanced and more consistent with copy-check.

I agree ✅ for changing those.

@ericfennis
Copy link
Member

@karsa-mistmere Thanks for reply, this way better to the eye!

@MaxTechnics
Copy link
Contributor

The larger checkmark indeed seems to look a lot more balanced

@github-actions github-actions bot added the Stale label Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎨 icon About new icons 🫧 metadata Improved metadata
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants