Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(icons): Updated sandwich icon #2494

Merged
merged 4 commits into from
Oct 8, 2024
Merged

Conversation

jamiemlaw
Copy link
Contributor

Rounded the top-front corners, and better aligned the top-most corner of the bread, and the corner of the filling to the grid

What is the purpose of this pull request?

  • Other: Icon update

Description

Rounded the top-front corners, and better aligned the top-most corner of the bread, and the corner of the filling to the grid

Before Submitting

Rounded the top-front corners, and better aligned the top-most corner of the bread, and the corner of the filling to the grid
Nudge filling to the left to maintain a two-pixel gap
@github-actions github-actions bot added 🎨 icon About new icons 🫧 metadata Improved metadata labels Sep 25, 2024
Copy link

github-actions bot commented Sep 25, 2024

Added or changed icons

icons/sandwich.svg

Preview cohesion icons/square-power.svg
icons/sandwich.svg
icons/hand-helping.svg
Preview stroke widths icons/sandwich.svg
icons/sandwich.svg
icons/sandwich.svg
DPI Preview (24px) icons/sandwich.svg
Icon X-rays icons/sandwich.svg
Icon Diffs icons/sandwich.svg
Icons as code

Works for: lucide-react, lucide-react-native, lucide-preact, lucide-vue-next

const SandwichIcon = createLucideIcon('Sandwich', [
  ["path",{"d":"m2.37 11.223 8.372-6.777a2 2 0 0 1 2.516 0l8.371 6.777"}],
  ["path",{"d":"M21 15a1 1 0 0 1 1 1v2a1 1 0 0 1-1 1h-5.25"}],
  ["path",{"d":"M3 15a1 1 0 0 0-1 1v2a1 1 0 0 0 1 1h9"}],
  ["path",{"d":"m6.67 15 6.13 4.6a2 2 0 0 0 2.8-.4l3.15-4.2"}],
  ["rect",{"width":"20","height":"4","x":"2","y":"11","rx":"1"}]
])

@jguddas
Copy link
Member

jguddas commented Sep 25, 2024

That icon is also too small, we could maybe even fix the size.

@jamiemlaw
Copy link
Contributor Author

That icon is also too small, we could maybe even fix the size.

Was literally thinking that. I opened up burger to see if I needed to update its cheese to match this icon, and noticed the size discrepancy.

Wider sandwich

icons
Open lucide studio

Updated burger (for a different PR if necessary)

icons
Open lucide studio

@jamiemlaw jamiemlaw changed the title Updated sandwich icon fix(icons): Updated sandwich icon Sep 25, 2024
@jguddas
Copy link
Member

jguddas commented Sep 26, 2024

Maybe move everything up 1px?

icons
Open lucide studio

Copy link
Member

@ericfennis ericfennis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice this looks better!

@ericfennis ericfennis merged commit 2a68b12 into lucide-icons:main Oct 8, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎨 icon About new icons 🫧 metadata Improved metadata
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants