Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add separator icons #47

Merged
merged 5 commits into from
Sep 3, 2020

Conversation

ericfennis
Copy link
Member

Contributes to: #766

image

@ericfennis
Copy link
Member Author

I'm thinking making a second pair more looking like this.
image

@ericfennis
Copy link
Member Author

I added two extra icons, but I don't know if the top ones are fitting the name separator? 🤔
image

@dgdavid
Copy link

dgdavid commented Jul 2, 2020

Honestly, the top ones looks a bit weird as "separators". If you ask me, I'd say I prefer the last ones.

@ericfennis
Copy link
Member Author

@dgdavid I totally agree.
the top ones look more like split-panes.

@ericfennis
Copy link
Member Author

I removed the other two, so it is just those two.
image

@ericfennis ericfennis requested a review from johnletey July 5, 2020 09:49
Copy link
Contributor

@moeenio moeenio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd call the removed ones split btw.

Copy link
Collaborator

@johnletey johnletey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ericfennis Is it just me or is the length of the line too long? Maybe either shorten it or increase the padding between the "brackets" and the line?

Idk just my thoughts.

@ericfennis
Copy link
Member Author

@jletey I will try it, to shorten the line. For the brackets I tried, but it looked a bit weird. I think the 2px padding is fits the best.

@johnletey
Copy link
Collaborator

@ericfennis Sounds good, let me know what you come up with!

@ericfennis
Copy link
Member Author

ericfennis commented Jul 17, 2020

@jletey On the top are the one with shorter lines.

@ericfennis
Copy link
Member Author

I implemented the top ones, thanks for the feedback!

@ericfennis ericfennis merged commit e1cead9 into lucide-icons:master Sep 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants