-
-
Notifications
You must be signed in to change notification settings - Fork 517
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add separator icons #47
Conversation
Honestly, the top ones looks a bit weird as "separators". If you ask me, I'd say I prefer the last ones. |
@dgdavid I totally agree. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd call the removed ones split
btw.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ericfennis Is it just me or is the length of the line too long? Maybe either shorten it or increase the padding between the "brackets" and the line?
Idk just my thoughts.
@jletey I will try it, to shorten the line. For the brackets I tried, but it looked a bit weird. I think the 2px padding is fits the best. |
@ericfennis Sounds good, let me know what you come up with! |
@jletey On the top are the one with shorter lines. |
I implemented the top ones, thanks for the feedback! |
Contributes to: #766