Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add save-as icon and save alternative #645

Closed
wants to merge 1 commit into from

Conversation

lscheibel
Copy link
Member

I had these a bit more modern looking alternatives for save icons lying around for a while now.

This would also address feathericons/feather#609

image

@lscheibel lscheibel changed the title Add save-as icon and save alternative Add save-as icon and save alternative May 1, 2022
@karsa-mistmere
Copy link
Member

Not bad (certainly solves the save as fiasco), but maybe the arrow could be a bit more pronounced (this would also make the icon more visually centered):
image
save

@karsa-mistmere
Copy link
Member

Sidenote: if we add this alternate save icon, I think a matching load icon should be trivial. :)

@ericfennis
Copy link
Member

@lscheibel Nice love the alternative ones.

@lscheibel
Copy link
Member Author

I agree, that the arrow is better readable when increased in size, however just increasing it's size makes the icon feel packed/dense. Instead we could also increase the bounds size like so:

image

image

This goes against the 1px margin guideline, however I like this much better than truncating the arrows tail.

@karsa-mistmere
Copy link
Member

karsa-mistmere commented May 3, 2022

Yeah, that particular guideline is pretty crucial, so that 3px strokes do not overflow or get clipped.

I've been doodling around, here are a few alternate versions:
image
save icons

I've also been wondering whether it is preferable to keep the arrows consistent between the two icons (top row) or keep the centre of gravity about the same (bottom row):
image

What do you think, @ericfennis?

@ericfennis
Copy link
Member

Sorry for late reply, was on vacation.
Hmm I'm not sure yet of the whole concept of the icon. I'm not sure if this icon is recognisable enough as a "save-as" icon.
Do we have some examples of icons have this as a save-as icon?

@karsa-mistmere
Copy link
Member

Yeah, I also have my doubts. From what I could find this design originates from a submission to a competition to redesign the save as icon:

Not sure if anyone ever actually used it, at least I couldn't find any icon sets actually containing an icon like this for either save or save as.

@karsa-mistmere karsa-mistmere mentioned this pull request Jun 15, 2022
9 tasks
@github-actions
Copy link

github-actions bot commented Jul 9, 2022

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@github-actions github-actions bot added the Stale label Jul 9, 2022
@ericfennis
Copy link
Member

This one needs more exploration, to something recognisable. I close this one for now.

@ericfennis ericfennis closed this Jul 22, 2022
@lscheibel lscheibel deleted the save-as branch September 7, 2022 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants