Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve bug icons #988

Merged
merged 9 commits into from
Aug 28, 2023
Merged

Improve bug icons #988

merged 9 commits into from
Aug 28, 2023

Conversation

danielbayley
Copy link
Member

@danielbayley danielbayley commented Mar 28, 2023

Update:

Untitled

Artboard 1@2x

Full preview here: #988 (comment)

@karsa-mistmere
Copy link
Member

karsa-mistmere commented Mar 29, 2023

Nice designs, but as with #987, adding both is simply not justified, they're just far too similar.

I do emphasise, since I myself don't really like the current bug icon and pretty much always use this alternate design as a manual entry instead. 😛
image

One issue with your designs though, is that the legs are a bit too close to each other and dense on 100% view.
Although I like the legs, I might very well copy them to my "fork" of bug. 🙂
image

@danielbayley
Copy link
Member Author

adding both is simply not justified, they're just far too similar.

@karsa-mistmere Yeah, I think we should settle on just one version, so maybe replace the existing bug icon? Just a single commit now…

@github-actions
Copy link

github-actions bot commented Apr 5, 2023

Added or changed icons

icons/bug-off.svg icons/bug-play.svg icons/bug.svg

Preview cohesion icons/chevron-right-square.svg icons/arrow-right-square.svg icons/message-square-plus.svg
icons/bug-off.svg icons/bug-play.svg icons/bug.svg
icons/battery.svg icons/spell-check.svg icons/badge-dollar-sign.svg
Preview stroke widths icons/bug-off.svg icons/bug-play.svg icons/bug.svg
icons/bug-off.svg icons/bug-play.svg icons/bug.svg
icons/bug-off.svg icons/bug-play.svg icons/bug.svg
DPI Preview (24px) icons/bug-off.svg icons/bug-play.svg icons/bug.svg
Icon X-rays icons/bug-off.svg icons/bug-play.svg icons/bug.svg

icons/debug.svg Outdated Show resolved Hide resolved
@ericfennis
Copy link
Member

Hmm I think not agree with replacing the existing bug icon. They are similar if you look them in scaled version but on 100% they look different. So maybe reconsider this?

@danielbayley
Copy link
Member Author

Hmm I think not agree with replacing the existing bug icon. They are similar if you look them in scaled version but on 100% they look different. So maybe reconsider this?

I mean the existing bug icon is pretty weak compared to any of these… The debug idea should be assessed separately…

@karsa-mistmere
Copy link
Member

While I do personally like the more organic look, there's still the issue of the legs being too close to each other resulting in too high of a density near the body, which is especially present at higher stroke widths & smaller sizes:
image

@danielbayley
Copy link
Member Author

While I do personally like the more organic look, there's still the issue of the legs being too close to each other resulting in too high of a density near the body, which is especially present at higher stroke widths & smaller sizes: image

Addressed in the latest commit…

icons/bug.svg Outdated Show resolved Hide resolved
@danielbayley
Copy link
Member Author

#988 (comment)
Can you resolve the conflicts and see if that helps @danielbayley?

@jguddas That seems to have partially fixed it, but still something strange going on with bug-play

@ericfennis
Copy link
Member

I want to vote on this one. Everyone can vote with a reaction emoji.

image

@ericfennis
Copy link
Member

Ok, current design it is!

@ericfennis
Copy link
Member

ericfennis commented Aug 18, 2023

I've one final request for the bug-x icon. I think the X in the center of the bug is not really communicating the "remove" on this one. To me it looks a bit like it's part of the bug.
I think we should place the X on the same location as the bug-play icon.

@vercel
Copy link

vercel bot commented Aug 18, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lucide ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 18, 2023 8:35pm

@danielbayley
Copy link
Member Author

I want to vote on this one. Everyone can vote with a reaction emoji.

Nice! We need this feature in comment bot form though… :)

I've one final request for the bug-x icon. I think the X in the center of the bug is not really communicating the "remove" on this one. To me it looks a bit like it's part of the bug. I think we should place the X on the same location as the bug-play icon.

@ericfennis I much prefer the x in the centre… But if you insist I have added the same variant pair as file-x-2 etc.

@jguddas
Copy link
Member

jguddas commented Aug 19, 2023

x feels to small, can we split the bug-x of into a separate PR and get the rest merged?

@ericfennis
Copy link
Member

@danielbayley Hmm yeah but to me, the X not communicating the right thing here.
And I agree with @jguddas X is also too small.

@ericfennis ericfennis merged commit 8b7ea73 into lucide-icons:main Aug 28, 2023
3 checks passed
@danielbayley
Copy link
Member Author

x feels to small
I agree with @jguddas X is also too small.

@jguddas @ericfennis How can that be the case, if it uses exactly the same size x as the existing calendar-x, mail-x, list-x icons… and probably others?

the X not communicating the right thing here.

Hmm, well it’s communicating the same thing as Codicons debug is here: https://github.com/microsoft/vscode-codicons/blob/main/src/icons/debug.svg, as in squishing/eliminating bugs, and another use case I can think of outside of development would be pest control…

@danielbayley danielbayley deleted the bugs branch January 16, 2024 20:38
@jguddas
Copy link
Member

jguddas commented Jan 16, 2024

Would be great if you could create a PR for bug-x than we can see the low dpi preview for the x.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎨 icon About new icons 🫧 metadata Improved metadata
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants