Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow human-friendly translations for facet fields to be defined on a per-dashboard basis #217

Merged
merged 4 commits into from
Jun 19, 2015

Conversation

davidfmiller
Copy link
Contributor

No description provided.

@davidfmiller
Copy link
Contributor Author

A fix for this issue: #207

@davidfmiller
Copy link
Contributor Author

Example modification to dashboard config file in order for the lang keys to be supported:

{
    ...
    "solr": { ... },
    "group": "Default",
    "lang" : {
        "facet.leadGroup" : "Lead Group",
        "facet.syndicationPartner" : "Syndication Partner",
        "facet.trackingReferringUrl" : "Referring URL",
        "facet.leadType" : "Lead Type",
        "facet.leadCategory" : "Lead Category"
    }
}

screen shot 2015-06-17 at 10 52 19 am

@aadel
Copy link
Contributor

aadel commented Jun 18, 2015

@davidfmiller very nice! I have two additions though:

  • there are some places where human friendly names can be used, such as Table field list, FTS.
  • it would be nice to have a more user friendly dashboard-wide setting to define the pairs, something like a new tab to "Dashboard Settings".

@davidfmiller
Copy link
Contributor Author

I'll add the translation to the Table & FTS panels and update the PR.

Creating Dashboard setting/administration is a good idea, I'll put that on my todo list and start digging into it as time allows!

@davidfmiller
Copy link
Contributor Author

Updated! Let me know what you think, thanks.

@aadel aadel merged commit ea1218f into lucidworks:develop Jun 19, 2015
@aadel
Copy link
Contributor

aadel commented Jun 19, 2015

Looks good! Fixed an issue in FTS (aa3efdf) and merged.

@davidfmiller
Copy link
Contributor Author

Derp! Thanks,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants