use path instead of posix-specific path #40
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
addresses #38, but likely doesn't fully eliminate the issue.
I've noticed that there's a lot of explicit
posix
type path usage and manual path parsing etc. It seems to me that the scope of the extension is merely a bridge between karma/angular-cli and the UI, which leads me to believe that manual path wrangling (posix paths on windows and vice versa) shouldn't really be necessary.I don't want to break stuff I don't fully understand, so I only took out any posix path manipulation that touches
angularConfigRootPath
inangular-utils
since I can see that it's a windows path from the start, but I'm certain that the same could be done throughout the project. I generally advise against manual path manipulation and explicit platform distinction.This change correctly identifed my angular project on my D: drive and started the angular cli (without any manual settings). Test detection and execution work as expected. I did
npm validate
and got 225/238 tests passed, the same as onmaster
.I've taken the liberty to increment the path level.