-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add reCAPTCHA and optional disable flag for user registration #749
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…h reCAPTCHA v2, not v3.
dismantl
requested review from
redshiftzero,
abandoned-prototype and
brianmwaters
July 22, 2020 19:52
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
Ready for review
Description of Changes
This allows you to completely disable user registration by setting the environment variable
DISABLE_REGISTRATION
. Additionally, you can add Google reCAPTCHA v3 to the user registration page by setting theRECAPTCHA_V3_SITE_KEY
,RECAPTCHA_V3_SECRET_KEY
, and optionallyRECAPTCHA_V3_THRESHOLD
environment variables.To Test
Set up a recaptcha v3 site with Google (using localhost and 127.0.0.1 for domain names) and add the site key and secret key to the
.env
file using above environment variables. Thenmake dev
and register a user. You can then see the recaptcha score assigned to that registration by checking the docker logs. You should see something like this:Notes for Deployment
Screenshots (if appropriate)
Tests and linting
I have rebased my changes on current
develop
pytests pass in the development environment on my local machine
flake8
checks pass