Move models to its own package
#963
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Once the linked PR is done, I can submit this one: #944 |
michplunkett
commented
Jul 6, 2023
Comment on lines
-619
to
-622
| @login_manager.user_loader | ||
| def load_user(user_id): | ||
| return User.query.get(int(user_id)) |
There was a problem hiding this comment.
This was moved to prevent a circular import error.
michplunkett
changed the title
models to its own package
michplunkett
commented
Jul 7, 2023
Comment on lines
-99
to
+30
| BaseConfig.OO_SERVICE_EMAIL | ||
| current_app.config["OO_SERVICE_EMAIL"] |
There was a problem hiding this comment.
This should address this build error: https://github.com/lucyparsons/OpenOversight/actions/runs/5488540812
abandoned-prototype
approved these changes
Jul 10, 2023
There was a problem hiding this comment.
This looks good. Definitely nice how many local imports you could get rid of.
The only thing that stands out to me is the formatting of some commands. Did you run a different command? Maybe you could undo that, or take a quick look and fix the cases where moving a newline made the sentence less readable
|
If anything breached the 88-character limit (the one that we used in Black), I then broke it at the closest point that made sense. I can adjust those so that it doesn't produce the issues you brought up! Thanks for takin' a look and I'll take care of that now! |
michplunkett
commented
Jul 10, 2023
| @@ -62,8 +78,9 @@ def pick_birth_date(): | |||
|
|
|||
|
|
|||
| def pick_date(seed: bytes = None, start_year=2000, end_year=2020): | |||
| # source: https://stackoverflow.com/questions/40351791/how-to-hash-strings-into-a-float-in-01 | |||
| # Wanted to deterministically create a date from a seed string (e.g. the hash or uuid on an officer object) | |||
| # source: https://stackoverflow.com/q/40351791 | |||
There was a problem hiding this comment.
I took the small link from the Share option, and now we have less link gore:
michplunkett
commented
Jul 10, 2023
Comment on lines
-102
to
+114
| (HTTPStatus.FORBIDDEN, "Forbidden", "403.html"), | ||
| (HTTPStatus.NOT_FOUND, "Not found", "404.html"), | ||
| (HTTPStatus.REQUEST_ENTITY_TOO_LARGE, "File too large", "413.html"), | ||
| (HTTPStatus.TOO_MANY_REQUESTS, "Too many requests", "429.html"), | ||
| (HTTPStatus.INTERNAL_SERVER_ERROR, "Internal Server Error", "500.html"), | ||
| (HTTPStatus.FORBIDDEN, HTTPStatus.FORBIDDEN.phrase, "403.html"), | ||
| (HTTPStatus.NOT_FOUND, HTTPStatus.NOT_FOUND.phrase, "404.html"), | ||
| ( | ||
| HTTPStatus.REQUEST_ENTITY_TOO_LARGE, | ||
| HTTPStatus.REQUEST_ENTITY_TOO_LARGE.phrase, | ||
| "413.html", | ||
| ), | ||
| (HTTPStatus.TOO_MANY_REQUESTS, HTTPStatus.TOO_MANY_REQUESTS.phrase, "429.html"), | ||
| ( | ||
| HTTPStatus.INTERNAL_SERVER_ERROR, | ||
| HTTPStatus.INTERNAL_SERVER_ERROR.phrase, | ||
| "500.html", | ||
| ), |
There was a problem hiding this comment.
sea-kelp
pushed a commit
to OrcaCollective/OpenOversight
that referenced
this pull request
Sep 6, 2023
lucyparsons#959 Move `models` to its own package to prevent circular dependencies and address straggling relative imports. - [x] This branch is up-to-date with the `develop` branch. - [x] `pytest` passes on my local development environment. - [x] `pre-commit` passes on my local development environment.
sea-kelp
pushed a commit
to OrcaCollective/OpenOversight
that referenced
this pull request
Sep 25, 2023
lucyparsons#959 Move `models` to its own package to prevent circular dependencies and address straggling relative imports. - [x] This branch is up-to-date with the `develop` branch. - [x] `pytest` passes on my local development environment. - [x] `pre-commit` passes on my local development environment.
sea-kelp
pushed a commit
to OrcaCollective/OpenOversight
that referenced
this pull request
Oct 5, 2023
lucyparsons#959 Move `models` to its own package to prevent circular dependencies and address straggling relative imports. - [x] This branch is up-to-date with the `develop` branch. - [x] `pytest` passes on my local development environment. - [x] `pre-commit` passes on my local development environment.
AetherUnbound
pushed a commit
to OrcaCollective/OpenOversight
that referenced
this pull request
Oct 9, 2023
lucyparsons#959 Move `models` to its own package to prevent circular dependencies and address straggling relative imports. - [x] This branch is up-to-date with the `develop` branch. - [x] `pytest` passes on my local development environment. - [x] `pre-commit` passes on my local development environment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue
#959
Description of Changes
Move
modelsto its own package to prevent circular dependencies and address straggling relative imports.Tests and linting
developbranch.pytestpasses on my local development environment.pre-commitpasses on my local development environment.