Add context as parameter to EmailClient
#964
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sea-kelp
pushed a commit
to OrcaCollective/OpenOversight
that referenced
this pull request
Sep 6, 2023
## Fixes Issue https://github.com/lucyparsons/OpenOversight/actions/runs/5510368096/jobs/10044531971 ## Description of Changes For the config to be properly accessed in the `email_client`, a `with app.context:` line needed to be added or the config needed to be added as a parameter to the `EmailClient`. ## Notes for Deployment This should fix the issue. ## Screenshots (if appropriate) - Validated fix by creating a new user on my local development environment. <img width="1139" alt="Screenshot 2023-07-10 at 11 26 55 AM" src="https://github.com/lucyparsons/OpenOversight/assets/5885605/615add77-0f11-4c46-885d-58826000974c"> ## Tests and linting - [x] This branch is up-to-date with the `develop` branch. - [x] `pytest` passes on my local development environment. - [x] `pre-commit` passes on my local development environment.
sea-kelp
pushed a commit
to OrcaCollective/OpenOversight
that referenced
this pull request
Sep 25, 2023
## Fixes Issue https://github.com/lucyparsons/OpenOversight/actions/runs/5510368096/jobs/10044531971 ## Description of Changes For the config to be properly accessed in the `email_client`, a `with app.context:` line needed to be added or the config needed to be added as a parameter to the `EmailClient`. ## Notes for Deployment This should fix the issue. ## Screenshots (if appropriate) - Validated fix by creating a new user on my local development environment. <img width="1139" alt="Screenshot 2023-07-10 at 11 26 55 AM" src="https://github.com/lucyparsons/OpenOversight/assets/5885605/615add77-0f11-4c46-885d-58826000974c"> ## Tests and linting - [x] This branch is up-to-date with the `develop` branch. - [x] `pytest` passes on my local development environment. - [x] `pre-commit` passes on my local development environment.
sea-kelp
pushed a commit
to OrcaCollective/OpenOversight
that referenced
this pull request
Oct 5, 2023
## Fixes Issue https://github.com/lucyparsons/OpenOversight/actions/runs/5510368096/jobs/10044531971 ## Description of Changes For the config to be properly accessed in the `email_client`, a `with app.context:` line needed to be added or the config needed to be added as a parameter to the `EmailClient`. ## Notes for Deployment This should fix the issue. ## Screenshots (if appropriate) - Validated fix by creating a new user on my local development environment. <img width="1139" alt="Screenshot 2023-07-10 at 11 26 55 AM" src="https://github.com/lucyparsons/OpenOversight/assets/5885605/615add77-0f11-4c46-885d-58826000974c"> ## Tests and linting - [x] This branch is up-to-date with the `develop` branch. - [x] `pytest` passes on my local development environment. - [x] `pre-commit` passes on my local development environment.
AetherUnbound
pushed a commit
to OrcaCollective/OpenOversight
that referenced
this pull request
Oct 9, 2023
## Fixes Issue https://github.com/lucyparsons/OpenOversight/actions/runs/5510368096/jobs/10044531971 ## Description of Changes For the config to be properly accessed in the `email_client`, a `with app.context:` line needed to be added or the config needed to be added as a parameter to the `EmailClient`. ## Notes for Deployment This should fix the issue. ## Screenshots (if appropriate) - Validated fix by creating a new user on my local development environment. <img width="1139" alt="Screenshot 2023-07-10 at 11 26 55 AM" src="https://github.com/lucyparsons/OpenOversight/assets/5885605/615add77-0f11-4c46-885d-58826000974c"> ## Tests and linting - [x] This branch is up-to-date with the `develop` branch. - [x] `pytest` passes on my local development environment. - [x] `pre-commit` passes on my local development environment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Issue
https://github.com/lucyparsons/OpenOversight/actions/runs/5510368096/jobs/10044531971
Description of Changes
For the config to be properly accessed in the
email_client, awith app.context:line needed to be added or the config needed to be added as a parameter to theEmailClient.Notes for Deployment
This should fix the issue.
Screenshots (if appropriate)
Tests and linting
developbranch.pytestpasses on my local development environment.pre-commitpasses on my local development environment.