Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional /timezone test #989

Merged
merged 2 commits into from
Jul 25, 2023

Conversation

michplunkett
Copy link
Collaborator

@michplunkett michplunkett commented Jul 24, 2023

Fixes issue

#323

Description of Changes

Added test to cover an empty string timezone being passed.

Tests and linting

  • This branch is up-to-date with the develop branch.
  • pytest passes on my local development environment.
  • pre-commit passes on my local development environment.

@michplunkett michplunkett self-assigned this Jul 24, 2023
@michplunkett michplunkett linked an issue Jul 24, 2023 that may be closed by this pull request
@@ -58,12 +58,26 @@ def test_user_can_access_profile_differently_cased(mockdata, client, session):

def test_timezone_setting(client):
with current_app.test_request_context():
test_tz = FAKER.timezone()
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@abandoned-prototype abandoned-prototype merged commit 4500b87 into develop Jul 25, 2023
2 checks passed
@abandoned-prototype abandoned-prototype deleted the add_additional_timezone_test branch July 25, 2023 04:47
sea-kelp pushed a commit to OrcaCollective/OpenOversight that referenced this pull request Sep 24, 2023
## Fixes issue
lucyparsons#323

## Description of Changes
Added test to cover an empty string timezone being passed.
sea-kelp pushed a commit to OrcaCollective/OpenOversight that referenced this pull request Sep 25, 2023
## Fixes issue
lucyparsons#323

## Description of Changes
Added test to cover an empty string timezone being passed.
AetherUnbound pushed a commit to OrcaCollective/OpenOversight that referenced this pull request Oct 9, 2023
## Fixes issue
lucyparsons#323

## Description of Changes
Added test to cover an empty string timezone being passed.
AetherUnbound pushed a commit to OrcaCollective/OpenOversight that referenced this pull request Oct 9, 2023
## Fixes issue
lucyparsons#323

## Description of Changes
Added test to cover an empty string timezone being passed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Set timestamp columns in the database to timestamptz
2 participants