-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add additional /timezone
test
#989
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michplunkett
commented
Jul 24, 2023
@@ -58,12 +58,26 @@ def test_user_can_access_profile_differently_cased(mockdata, client, session): | |||
|
|||
def test_timezone_setting(client): | |||
with current_app.test_request_context(): | |||
test_tz = FAKER.timezone() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
abandoned-prototype
approved these changes
Jul 25, 2023
sea-kelp
pushed a commit
to OrcaCollective/OpenOversight
that referenced
this pull request
Sep 24, 2023
## Fixes issue lucyparsons#323 ## Description of Changes Added test to cover an empty string timezone being passed.
sea-kelp
pushed a commit
to OrcaCollective/OpenOversight
that referenced
this pull request
Sep 25, 2023
## Fixes issue lucyparsons#323 ## Description of Changes Added test to cover an empty string timezone being passed.
AetherUnbound
pushed a commit
to OrcaCollective/OpenOversight
that referenced
this pull request
Oct 9, 2023
## Fixes issue lucyparsons#323 ## Description of Changes Added test to cover an empty string timezone being passed.
AetherUnbound
pushed a commit
to OrcaCollective/OpenOversight
that referenced
this pull request
Oct 9, 2023
## Fixes issue lucyparsons#323 ## Description of Changes Added test to cover an empty string timezone being passed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue
#323
Description of Changes
Added test to cover an empty string timezone being passed.
Tests and linting
develop
branch.pytest
passes on my local development environment.pre-commit
passes on my local development environment.