Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Add HttpStatusCodeLiteral 451 #1284

Merged
merged 4 commits into from
Jul 25, 2022

Conversation

jokj624
Copy link
Contributor

@jokj624 jokj624 commented Jul 17, 2022

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you written unit tests?
  • Have you written unit tests that cover the negative cases (i.e.: if bad data is submitted, does the library respond properly)?
  • This PR is associated with an existing issue?

Closing issues

closes #1277

If this is a new feature submission:

  • Has the issue had a maintainer respond to the issue and clarify that the feature is something that aligns with the goals and philosophy of the project?

Potential Problems With The Approach

Test plan

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello there jokj624 👋

Thank you and congrats 🎉 for opening your first PR on this project.✨

We will review the following PR soon! 👀

@jokj624 jokj624 changed the title Fix: HttpStatusCodeLiteral 451 Fix: Add HttpStatusCodeLiteral 451 Jul 17, 2022
@WoH
Copy link
Collaborator

WoH commented Jul 25, 2022

Afaik last time I was running into the discrepancies, Koa didn't support this.
https://github.com/koajs/koa/blob/master/docs/api/response.md

But the tests speak for themselves. LGTM, thanks!

@WoH WoH merged commit 0d48d2b into lukeautry:master Jul 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support HTTP status 451 Unavailable For Legal Reasons
2 participants